cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: return a state instead of null in Abstrac...
Date Fri, 01 May 2015 10:09:59 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/211#issuecomment-98091566
  
    Abhinandan, I think that is a design flow and we should revisit. I doubt
    that it is relevant to this fix however. The stjatemachine was resetting
    the state of an object to null, which should never happen. especially with
    a state enum of
    
        Creating(true, false, false),
    
        Connecting(true, false, false),
    
        Up(true, false, false),
    
        Down(true, true, true),
    
        Disconnected(true, true, true),
    
        Alert(true, true, true),
    
        Removed(true, false, true),
    
        Error(true, false, true),
    
        Rebalancing(true, false, true);
    The page you mention has been last edited Sep 13, 2013. By capable people
    but can still be considered outdated. I think if we need to we should add
    UNKNOWN to the states but we shouldn't return null.
    
    Op vr 1 mei 2015 om 11:55 schreef Abhinandan Prateek <
    notifications@github.com>:
    
    > The way HA is implemented, “null” is a valid return value from an
    > investigator. The valid values are Up, Down or null.
    >
    > https://cwiki.apache.org/confluence/display/CLOUDSTACK/High+Availability+Developer's+Guide
    > The other values may not be handled by HA impl., please check.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/211#issuecomment-98087158>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message