cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request: return a state instead of null in Abstrac...
Date Fri, 01 May 2015 10:09:36 GMT
Github user abhinandanprateek commented on the pull request:

    https://github.com/apache/cloudstack/pull/211#issuecomment-98091401
  
    I agree with Koushik here. The purpose of an HA investigator is to either say that host
is UP or Down or it does not know for sure.  A host that has not returned some pings is in
an indeterministic state, HA recognises it as "null" and not as Alert.
    That apart there are there places that the method changed gets called. If you look at
the code the Alert state does not have any affect on the code flow. I hope I did not miss
out some.
    I will say check again, as introduction of Alert state may confuse people looking at the
code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message