Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
Message-ID: <git-pr-186-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin
 should work...
Content-Type: text/plain
Date: Tue, 21 Apr 2015 15:50:12 +0000 (UTC)

GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/186

    CLOUDSTACK-8395: vmops plugin should work on both XS 6.5 and 6.2 :fist:

    This fixes the issue of Security Groups not working in case of XenServer 6.5;
    - Uses nethash ipset data-structure to store CIDRs (efficient than iphash and
      avoids overflow errors in case users add /8 /4 ingress/egress cidrs)
    - Support for ipset versions both on 6.2 and 6.5, both have different outputs. This
      fixes the issue of destroy_network_rules_for_vm failing
    - Implements defensive filtering of list, instead of popping last item without
      checking if it's None or empty
    - Greps using names that are 'quoted' to avoid bash errors
    - Before setting up new network rule, tries to clean and remove old ipset entry
    - Idents, whitespace and naming fixes
    
    PS. This is my 1000th commit to the :monkey_face: project :)
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/cloudstack CLOUDSTACK-8395

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit c11080a99d0479c51eaa4f2d2664ed7f8e348a5a
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2015-04-21T15:35:36Z

    CLOUDSTACK-8395: vmops plugin should work on both XS 6.5 and 6.2 :fist:
    
    This fixes the issue of Security Groups not working in case of XenServer 6.5;
    - Uses nethash ipset data-structure to store CIDRs (efficient than iphash and
      avoids overflow errors in case users add /8 /4 ingress/egress cidrs)
    - Support for ipset versions both on 6.2 and 6.5, both have different outputs. This
      fixes the issue of destroy_network_rules_for_vm failing
    - Implements defensive filtering of list, instead of popping last item without
      checking if it's None or empty
    - Greps using names that are 'quoted' to avoid bash errors
    - Before setting up new network rule, tries to clean and remove old ipset entry
    - Idents, whitespace and naming fixes
    
    PS. This is my 1000th commit to the :monkey_face: project :)
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---