Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B96991799B for ; Mon, 6 Apr 2015 20:08:45 +0000 (UTC) Received: (qmail 79762 invoked by uid 500); 6 Apr 2015 20:08:45 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 79713 invoked by uid 500); 6 Apr 2015 20:08:45 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 79696 invoked by uid 99); 6 Apr 2015 20:08:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Apr 2015 20:08:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 199D91D73E5; Mon, 6 Apr 2015 20:08:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0301662474950973764==" MIME-Version: 1.0 Subject: Re: Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services) From: "Sebastien Goasguen" To: "Hugo Trippaers" Cc: "Pradeep HK" , "Sebastien Goasguen" , "cloudstack" Date: Mon, 06 Apr 2015 20:08:43 -0000 Message-ID: <20150406200843.5637.68862@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sebastien Goasguen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/23257/ X-Sender: "Sebastien Goasguen" References: <20140724064516.4203.58374@reviews.apache.org> In-Reply-To: <20140724064516.4203.58374@reviews.apache.org> Reply-To: "Sebastien Goasguen" X-ReviewRequest-Repository: cloudstack-git --===============0301662474950973764== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23257/#review79038 ----------------------------------------------------------- Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On July 24, 2014, 6:45 a.m., Pradeep HK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23257/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 6:45 a.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-5398 > https://issues.apache.org/jira/browse/CLOUDSTACK-5398 > > > Repository: cloudstack-git > > > Description > ------- > > Pls refer to the Design document available @ > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29 > > This feature is about a Cloudstack network-element plugin to orchestrate Juniper's switches. > > As a first-cut, we are focussing on L2 services and we will write a NetworkGuru. As part of it's implement() method we will: > (1)Create the required logical interfaces on the Juniper switches (EX,QFX) > (2)Create the required VLANs on the Juniper switches (EX,QFX). > (3)Configure VLAN membership on the interfaces > > Our customers need this plugin in Cloudstack deployments to automatically orchestrate the Juniper switches to create Virtual Networks. > Without this plugin, there will be a manual intervention needed to configure the switches (after figuring out the > current configuration of the switch). > > We have a Network Management Platform (called JUNOS SPACE) which is heavily used by customers to orchestrate Juniper's networking devices. > It also exposes REST-ful APIs for integration with 3rdParty tools. > The proposed Juniper's Cloudstack network-element plugin leverages these REST-ful APIs to appropriately orchestrate Juniper's switches to > create Virtual Networks > > > Diffs > ----- > > client/pom.xml 29fef4f > debian/cloudstack-management.install ea3f93b > debian/rules 197e243 > deps/install-non-oss.sh 940bd32 > plugins/network-elements/juniper-networkguru/pom.xml PRE-CREATION > plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/module.properties PRE-CREATION > plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/spring-junipernetworkguru-context.xml PRE-CREATION > plugins/network-elements/juniper-networkguru/src/JuniperNetworkGuru.properties PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/guru/JuniperNetworkGuru.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDao.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDaoImpl.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/DeviceInterfacesMap.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ELSJunosL2XMLConfigs.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JuniperNDAPIConstants.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JunosL2XMLConfigs.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/LLDPNeighbors.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ShowHardwareModel.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/Utils.java PRE-CREATION > plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/netconfOperations/NetconfOperations.java PRE-CREATION > plugins/pom.xml b5e6a61 > > Diff: https://reviews.apache.org/r/23257/diff/ > > > Testing > ------- > > When a Network created from Cloudstack UI is assigned a vlan-id, the same gets orchestrated on the Juniper switches. > > We have tested the above scenarios : > (1)Various Hypervisors like KVM,VMWare,Xen > (2)LLDP is enabled on switches and hosts (to get info abt the switch-port connected to hosts) > (3)Integration with Network Director API 1.6 > > > Thanks, > > Pradeep HK > > --===============0301662474950973764==--