Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7452484075574943504=="
MIME-Version: 1.0
Subject: Re: Review Request 24794: Review request for CLOUDSTACK-6169 -
 assignVirtualMachine leaves associated tags assigned to old account
From: "Sebastien Goasguen" <runseb@gmail.com>
To: "Marcus Sorensen" <shadowsor@gmail.com>
Cc: "Namita Chaudhari" <namita.chaudhari@sungardas.com>,
 "Sebastien Goasguen" <runseb@gmail.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Mon, 06 Apr 2015 20:07:04 -0000
Message-ID: <20150406200704.5638.37903@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sebastien Goasguen" <noreply@reviews.apache.org>
References: <20140818095417.7621.47803@reviews.apache.org>
In-Reply-To: <20140818095417.7621.47803@reviews.apache.org>
Reply-To: "Sebastien Goasguen" <runseb@gmail.com>

--===============7452484075574943504==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24794/#review79031
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On Aug. 18, 2014, 9:54 a.m., Namita Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24794/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 9:54 a.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6169 and https://issues.apache.org/jira/browse/CLOUDSTACK-6169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6169
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned to old account
> 
> When a VM is assigned from one account to another, the tags associated to the VM points to the new account and not old one.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/tags/ResourceTagVO.java eadddd1 
>   engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java fffe2a47 
>   engine/schema/src/com/cloud/tags/dao/ResourceTagsDaoImpl.java 3611999 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e5de11f 
> 
> Diff: https://reviews.apache.org/r/24794/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Namita Chaudhari
> 
>


--===============7452484075574943504==--