Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============5458499279276511098=="
MIME-Version: 1.0
Subject: Re: Review Request 28579: CLOUDSTACK-7996: Fixed the script
 "test_tags.py" -
 Tags and Template should belong to the User Account to test the case
From: "Sebastien Goasguen" <runseb@gmail.com>
To: "sangeetha hariharan" <sangeetha.hariharan@citrix.com>
Cc: "Chandan Purushothama" <Chandan.Purushothama@citrix.com>,
 "Sebastien Goasguen" <runseb@gmail.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Mon, 06 Apr 2015 20:01:33 -0000
Message-ID: <20150406200133.18051.95910@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sebastien Goasguen" <noreply@reviews.apache.org>
References: <20141201223553.32525.56671@reviews.apache.org>
In-Reply-To: <20141201223553.32525.56671@reviews.apache.org>
Reply-To: "Sebastien Goasguen" <runseb@gmail.com>

--===============5458499279276511098==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28579/#review79006
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On Dec. 1, 2014, 10:35 p.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28579/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 10:35 p.m.)
> 
> 
> Review request for cloudstack and sangeetha hariharan.
> 
> 
> Bugs: CLOUDSTACK-7996
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7996
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently the tags and template belong to the Admin Account and not the User Account. Listing tags is being done as the regular User Account. This results in test case failure as no tags are returned to the regular User. Hence the inconsistency in creation of template, tags and listing them needs to be corrected for the test case to work. 
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_tags.py c5a8ced 
> 
> Diff: https://reviews.apache.org/r/28579/diff/
> 
> 
> Testing
> -------
> 
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 441.116s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


--===============5458499279276511098==--