Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA55A17920 for ; Mon, 6 Apr 2015 20:00:55 +0000 (UTC) Received: (qmail 27336 invoked by uid 500); 6 Apr 2015 20:00:55 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 27284 invoked by uid 500); 6 Apr 2015 20:00:55 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 27263 invoked by uid 99); 6 Apr 2015 20:00:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Apr 2015 20:00:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 244D91D73E5; Mon, 6 Apr 2015 20:00:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6549400735986410226==" MIME-Version: 1.0 Subject: Re: Review Request 24991: CLOUDSTACK-6697: BigSwitchVns plugin update From: "Sebastien Goasguen" To: "David Nalley" , "Sebastien Goasguen" , "Hugo Trippaers" , "Chiradeep Vittal" Cc: "Kuang-Ching Wang" , "cloudstack" Date: Mon, 06 Apr 2015 20:00:53 -0000 Message-ID: <20150406200053.5637.26132@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sebastien Goasguen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24991/ X-Sender: "Sebastien Goasguen" References: <20141205010729.32526.66760@reviews.apache.org> In-Reply-To: <20141205010729.32526.66760@reviews.apache.org> Reply-To: "Sebastien Goasguen" X-ReviewRequest-Repository: cloudstack-git --===============6549400735986410226== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24991/#review79003 ----------------------------------------------------------- Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Dec. 5, 2014, 1:07 a.m., Kuang-Ching Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24991/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 1:07 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, David Nalley, Sebastien Goasguen, and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6697: Big Switch network plugin update > 1. provide compatibility with the Big Cloud Fabric (BCF) controller > L2 Connectivity Service in both VPC and non-VPC modes > 2. virtual network terminology updates: VNS --> BCF_SEGMENT > 3. uses HTTPS with trust-always certificate handling > 4. topology sync support with BCF controller > 5. support multiple (two) BCF controllers with HA > 6. support VM migration > > > Diffs > ----- > > api/src/com/cloud/network/Network.java c5a9bf286df8d502a6ca33661fb52ee717643566 > api/src/com/cloud/network/PhysicalNetwork.java 7c9349d932771fdbecc4a0b1ae4cad28b3d67857 > client/WEB-INF/classes/resources/messages.properties edaad29fffe05db8cd4628e9827456b073d7d6d6 > client/WEB-INF/classes/resources/messages_fr_FR.properties 54dc6215a8339b9f8c2bad9fe4c3ed18b4a702e7 > client/WEB-INF/classes/resources/messages_ja_JP.properties f9949fe4958d0c25fe0b5d8e29abcea35d7f27a5 > client/WEB-INF/classes/resources/messages_ko_KR.properties ced576cb23598e7d3e5005bc24c2adf20b66a826 > client/WEB-INF/classes/resources/messages_nl_NL.properties 86653a5f5144c75e67b5a6f02c47d37bd5a71ef0 > client/WEB-INF/classes/resources/messages_pt_BR.properties fa77633a650f1b37d8398a8936bbf84f5b4a40e3 > client/WEB-INF/classes/resources/messages_ru_RU.properties 7f57daa58bef379ddb47acb88965d0defe32ad73 > client/WEB-INF/classes/resources/messages_zh_CN.properties d02a124d1ccead641cdc92c3ac0c36a11b05b9bd > client/pom.xml 927cba7878bc8de20ecd7fa66516c322c52989f5 > client/tomcatconf/commands.properties.in 36d735da5581040b9e945c57492b3ec19d80ea08 > engine/schema/src/com/cloud/user/dao/VmDiskStatisticsDaoImpl.java e1136d3cf567b73fd1198181aea4d6995df6b78a > plugins/network-elements/bigswitch-vns/pom.xml afb267cdb5bc52aea23bc6739ea21d8f52e94ede > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/module.properties 5783d38e5cb78be0d418c80981246d721d18b62a > plugins/network-elements/bigswitch-vns/resources/META-INF/cloudstack/vns/spring-vns-context.xml d5bb92afe3d3051dbdd4b4d49698c313c77d255f > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java e950abe3bed85b75a20be2b8c4537a2fbd6be39e > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java 534bb7f9f9154a652a20310fe020bddc4249ef54 > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java 82c2fe90d63e0148bca8de9ce8612e4dd53cf735 > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java c3b9a9d6d9504e34cbe1294ac640f56aab101395 > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java 72ac98ac9e0a1ae4858019e3baccc160300e24bf > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java 6cf169bbfc97b57561af729aef297c76230fd118 > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java 076b187fdf48cf776902dc9a91dc26e00396158a > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java 0cae01d471dd9c5c504002c24f865ded59812d9e > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java 8310b0763708c3f049ef4ce427d09f0c07cd05b3 > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java 39cd26649c9bb0c4993f55bef65edfc326c4ceda > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java 40f09207606115a5d0ec7f9378c4c52d16405dfd > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java 5c6f555c8a40a4b785aed6fdfa743131006be209 > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java 1e2155dcd899bc11f9e9463cec432c020751e905 > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java 4cde78e503935f7ba3b4a90a6f4568f0dd32c7ab > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java 7942b6f2be3467465334b0628577b87564dbdab2 > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java 790ac9c6afbee9156cb8d26ee2a2b5980fe4ce18 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java 01b5d49a90bb4428716d6b9c344d4ccfc97fb34f > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/AttachmentData.java f1866e2621b6f9c19e4a9be310791b086ce3a350 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java 44445992858317e8e27ba45c13bd01ce1fbdef28 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java d03dc7c7d5b528402a2271c785507f6dbaef2705 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java 78ac02399d19818dcf37adcca5e13990a18ea44c > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/NetworkData.java e44c0f4f7dfb65ba89551d0a5afe50df40e61fbb > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/PortData.java d228d37caaceaf58232a41ac71a3d92ed6071b1b > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java da4e0035ebc041005b7379ece0407039bec13bbe > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java 0779ea2ae4edba02c6f0d4b009a3dbe4c39d98c9 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java c2b603221b34a5f71c6d1baafedcc7bd3810d11c > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java edcf6a148c3c6a052eb1a4e4caa7482c329584d4 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java 9805144ef92b06e3bcfaa4d31b74141d8f5e0266 > plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java 223972e2edcdc5fba114b13f7decd6c1704aaf46 > plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java 4d8021c5f77c910db36904fdb39d3934b657ed03 > plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java 8cf322ad19f8f8ad795edf18e4c939a6f88852ad > plugins/network-elements/bigswitch/findbugsExcludeFilter.xml PRE-CREATION > plugins/network-elements/bigswitch/pom.xml PRE-CREATION > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/module.properties PRE-CREATION > plugins/network-elements/bigswitch/resources/META-INF/cloudstack/bigswitch/spring-bigswitch-context.xml PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/BcfCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CacheBcfTopologyCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfAttachmentCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/CreateBcfSegmentCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfAttachmentCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/DeleteBcfSegmentCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerDataAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerDataCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerHostsAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/GetControllerHostsCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/StartupBigSwitchBcfCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/SyncBcfTopologyAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/SyncBcfTopologyCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentAnswer.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/agent/api/UpdateBcfAttachmentCommand.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/api/commands/AddBigSwitchBcfDeviceCmd.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/api/commands/BcfConstants.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/api/commands/DeleteBigSwitchBcfDeviceCmd.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/api/commands/ListBigSwitchBcfDevicesCmd.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/api/response/BigSwitchBcfDeviceResponse.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/BigSwitchBcfDeviceVO.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/AttachmentData.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApiException.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchStatus.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/Capabilities.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControlClusterData.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/ControllerData.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/NetworkData.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/TopologyData.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/TrustingProtocolSocketFactory.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDao.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/dao/BigSwitchBcfDaoImpl.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElement.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/element/BigSwitchBcfElementService.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/guru/BigSwitchBcfGuestNetworkGuru.java PRE-CREATION > plugins/network-elements/bigswitch/src/com/cloud/network/resource/BigSwitchBcfResource.java PRE-CREATION > plugins/network-elements/bigswitch/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION > plugins/network-elements/bigswitch/test/com/cloud/network/resource/BigSwitchBcfResourceTest.java PRE-CREATION > plugins/pom.xml 76119dc45467067fef91964eccb58d5f4c889ca9 > server/src/com/cloud/network/vpc/VpcManagerImpl.java fbb94c7ab0be7c2af86eeeb2a7fd61da27a91c5d > setup/db/db/schema-450to460.sql 0493184ec11649a308767ad3197961edb7321b8e > test/integration/component/test_bigswitch_bcf.py PRE-CREATION > tools/apidoc/gen_toc.py 95f06c8c1aa685c3b07967221e46daac0d34205c > tools/eclipse/eclipse.epf d7795aac4cf086f34169857b3048409a54932bb6 > ui/dictionary.jsp e1c19f36e581dc8a94e5c38038b3db4c5bfd8d3e > ui/dictionary2.jsp 98ecd5163f3052f4682810808a22ae9dabbdaca2 > ui/scripts/configuration.js 76b5b7b3cb3328228e5f11911ce84ae7cf427aea > ui/scripts/system.js 0444aafe206500331b3aae454d77ce8ef27fd86e > ui/scripts/ui-custom/zoneWizard.js 02552f92c09078bd1c4e91bbd01b41755c3d6d33 > > Diff: https://reviews.apache.org/r/24991/diff/ > > > Testing > ------- > > Passing unit tests > Added Marvin test (requires BCF controller) > Cleared Findbugs check > > > Thanks, > > Kuang-Ching Wang > > --===============6549400735986410226==--