cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravaradhye <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8377: Marvin - base library - ...
Date Sat, 11 Apr 2015 10:39:29 GMT
GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/156

    CLOUDSTACK-8377: Marvin - base library - Fix list method for PhysicalNetwork class

    Removed map() from list method for PhysicalNetwork class.
    map() function works only when the second argument is a list. However, when there are
no physical networks in the zone, the API will return None and it will be passed as second
argument to map. It will fail in this case.
    
    Instead return the API response as it is. No need to use map().
    
    Tested.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8377

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 1a2746ed00e60d32231342b7abb39ea71fa67282
Author: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
Date:   2015-04-11T10:36:31Z

    CLOUDSTACK-8377: Marvin - base library - Fix list method for PhysicalNetwork class

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message