cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravaradhye <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8375: Marvin - Code Improvemen...
Date Sat, 11 Apr 2015 09:16:56 GMT
GitHub user gauravaradhye opened a pull request:

    CLOUDSTACK-8375: Marvin - Code Improvement  - Verifying VCenter port groups corresponding
to traffic types in a zone

    1. Reducing complexity of function "verifyVCenterPortGroups". Earlier it had two for loops,
now it has only one. The parameter zone_list has been replaced with "zone" because we map
a VCenter to a zone and not multiple zones.
    2. Correcting the logic used to generate expected port group names for public traffic.
The port group with network rate as defined in "network.throttling.rate" is created only when
a VM is deployed and its network uses a public IP from public IP range dedicated to public
    3. Adding a wrapper function for verifying guest traffic port groups which creates vcenter
connection object and calls verifyVCenterPortGroups function with GUEST_TRAFFIC as parameter.
This function is very handy and can be called from any networking test case with only a single
line call. This separates the additional logic from test case and moves it to this wrapper
    The code has been tested against multiple types of Vmware deployments including mixture
tagged and untagged traffic types and mixed switches (SVS and DVS).

You can merge this pull request into a Git repository by running:

    $ git pull 8375

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
commit 1159089ca51ac44d41e565a2e0356741fe06b8ac
Author: Gaurav Aradhye <>
Date:   2015-04-11T09:07:28Z

    CLOUDSTACK-8375: Marvin - Code Improvement  - related to verifying VCenter port groups
corresponding to traffic types in a zone


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message