cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sateesh Chodapuneedi <sateesh.chodapune...@citrix.com>
Subject RE: [DISCUSS] Stop using Review Board
Date Fri, 03 Apr 2015 13:53:25 GMT
> -----Original Message-----
> From: Sebastien Goasguen [mailto:runseb@gmail.com]
> Sent: Friday, April 3, 2015 1:57 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Stop using Review Board
> 
> Seems with have lazy consensus.
> 
> Will Stevens contributed CONTRIBUTING instructions at:
> https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
> 
> I am pushing that to 4.5,4.4 and 4.3 and I will update our website contribution
> page, removing reference to RB.
> I will then put a message in the RB current reviews.
> 
> I propose to leave it a week with the message, this will give time to folks to
> move their review to GH.
> 
> After that, I will ask ASF infra to “hide” RB. They cannot make it readonly, we
> can only hide the view.

If RB is hidden, does that block us from seeing reviews of old patches on it?
Some of the commits doesn't have much meat in commit message, and in such cases used to go
back to RB where we could get some information seeing review history/comments.

Regards,
Sateesh
> 
> yell if you don’t like it :)
> 
> -sebastien
> 
> 
> > On Mar 31, 2015, at 5:17 AM, Rohit Yadav <rohit.yadav@shapeblue.com>
> wrote:
> >
> > +1
> >
> > Can we somehow disable RB for CloudStack project? We can run through
> pending RB patches and close them or move them to GH.
> >
> >> On 27-Mar-2015, at 8:50 pm, David Nalley <david@gnsa.us> wrote:
> >>
> >> +1 for GH
> >>
> >>
> >> On Fri, Mar 27, 2015 at 4:52 AM, Sebastien Goasguen <runseb@gmail.com>
> wrote:
> >>> Hi everyone,
> >>>
> >>> Since GitHub pull requests have been enabled for cloudstack, we have
> closed 127 commits.
> >>>
> >>> I believe this is a nicer interface, one that folks are used to when
> contributing to other open source projects.
> >>>
> >>> In the meantime, we still have 73 open reviews on Review Board
> >>>
> >>> https://reviews.apache.org/
> >>>
> >>> * I propose that we stop using RB all together, and remove any links to
it
> from our website and README.
> >>>
> >>> A few of us have tried to close some of the reviews by pinging the authors
> already.
> >>>
> >>> * My second proposition is that we write a comment in all reviews:
> >>>
> >>> “Thanks for the patch, the cloudstack community has decided to stop using
> Review Board in favor of github pull request.
> >>> You can see <link> to learn how to submit a pull request to cloudstack.
> Could you move your patch to a PR ?
> >>> Without response from you we will close this review within 7 days.
> >>> "
> >>>
> >>> There is good contribution guidelines in our docs README:
> >>> https://github.com/apache/cloudstack-docs
> >>>
> >>> -Sebastien
> >
> > Regards,
> > Rohit Yadav
> > Software Architect, ShapeBlue
> > M. +91 88 262 30892 | rohit.yadav@shapeblue.com
> > Blog: bhaisaab.org | Twitter: @_bhaisaab
> >
> >
> >
> > Find out more about ShapeBlue and our range of CloudStack related services
> >
> > IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-
> build//>
> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
> > CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-
> engineering/>
> > CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-
> infrastructure-support/>
> > CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-
> training/>
> >
> > This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based upon its
> contents, nor copy or show it to anyone. Please contact the sender if you
> believe you have received this email in error. Shape Blue Ltd is a company
> incorporated in England & Wales. ShapeBlue Services India LLP is a company
> incorporated in India and is operated under license from Shape Blue Ltd. Shape
> Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated
> under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered
> by The Republic of South Africa and is traded under license from Shape Blue Ltd.
> ShapeBlue is a registered trademark.

Mime
View raw message