cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Get usage records new input format start ...
Date Fri, 24 Apr 2015 22:59:05 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/191#discussion_r29092546
  
    --- Diff: server/src/com/cloud/usage/UsageServiceImpl.java ---
    @@ -224,11 +224,11 @@ public boolean generateUsageRecords(GenerateUsageRecordsCmd cmd)
{
                 throw new InvalidParameterValueException("Incorrect Date Range. Start date:
" + startDate + " is after end date:" + endDate);
             }
             TimeZone usageTZ = getUsageTimezone();
    -        Date adjustedStartDate = computeAdjustedTime(startDate, usageTZ, true);
    -        Date adjustedEndDate = computeAdjustedTime(endDate, usageTZ, false);
    +        Date adjustedStartDate = computeAdjustedTime(startDate, usageTZ);
    +        Date adjustedEndDate = computeAdjustedTime(endDate, usageTZ);
     
             if (s_logger.isDebugEnabled()) {
    -            s_logger.debug("getting usage records for account: " + accountId + ", domainId:
" + domainId + ", between " + startDate + " and " + endDate +
    +            s_logger.debug("getting usage records for account: " + accountId + ", domainId:
" + domainId + ", between " + djustedStartDate + " and " + adjustedEndDate +
    --- End diff --
    
    Can you fix the typo here, s/djustedStartDate/adjustedStartDate/ -- this is failing the
build.
    You may also squash the commits, and do a git push -f with your branch on your repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message