cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: KVM: make sure sync cannot block reboot
Date Thu, 09 Apr 2015 10:49:10 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/152#discussion_r28051897
  
    --- Diff: scripts/vm/hypervisor/kvm/kvmheartbeat.sh ---
    @@ -156,7 +156,8 @@ then
     elif [ "$cflag" == "1" ]
     then
       /usr/bin/logger -t heartbeat "kvmheartbeat.sh rebooted system because it was unable
to write the heartbeat to the storage."
    -  sync
    +  sync &
    --- End diff --
    
    what if sync takes more than 5 seconds?
    Why are we sync-ing at all if we don't want to block before rebooting?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message