cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
Date Mon, 06 Apr 2015 20:11:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19758/#review79049
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion
on the dev@cloudstack.apache.org the community decided to close down review board and start
accepting contributiong through GitHub pull requests. We have been using GH PR for several
months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to
a github PR if you wish. After that time, your patch will no longer be viewable (even though
it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that
using this new process will encourage you to do more.

- Sebastien Goasguen


On May 9, 2014, 5:36 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19758/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 5:36 a.m.)
> 
> 
> Review request for cloudstack and Rajesh Battala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  - Added new Network Service Provider "JuniperContrailvSRX".
>  - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider.
>    vSRX element currently supports only sourceNAT. It will be enhanced later to support
>    more features.
>  - Changes to service-instance creation code to use left virtual-network's SourceNAT
addr
>    as an interface address on vSRX instance's Public-network interface.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java ef3bcdf 
>   plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml
99ab02e 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java
PRE-CREATION 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
f34eacc 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java
49060f1 
> 
> Diff: https://reviews.apache.org/r/19758/diff/
> 
> 
> Testing
> -------
> 
> Performed unit tests with vSRX network service provider. Also other unit tests pass in
local testbed.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message