cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.
Date Mon, 06 Apr 2015 20:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22939/#review79033
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion
on the dev@cloudstack.apache.org the community decided to close down review board and start
accepting contributiong through GitHub pull requests. We have been using GH PR for several
months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to
a github PR if you wish. After that time, your patch will no longer be viewable (even though
it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that
using this new process will encourage you to do more.

- Sebastien Goasguen


On Aug. 8, 2014, 4:51 p.m., Simon Weller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22939/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 4:51 p.m.)
> 
> 
> Review request for cloudstack, edison su and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6460
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6460
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Addresses CLOUDSTACK-6460.
> CLVM storage source was being identified as QCOW2, rather than raw when attempting a
primary storage migration.  This caused the migration to fail when qemu-img attempted to image
the file back from secondary storage to the new primary storage selected. This patch forces
CLVM to be treated as RAW while continuing to acquire sourceFormat from other storage types
via disk.getFormat();
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
e9c588e 
> 
> Diff: https://reviews.apache.org/r/22939/diff/
> 
> 
> Testing
> -------
> 
> Stop VM. Migrate from one primary storage to another. Migration completes successfully.
Start vm.
> 
> 
> Thanks,
> 
> Simon Weller
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message