cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage
Date Mon, 06 Apr 2015 20:06:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review79027
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion
on the dev@cloudstack.apache.org the community decided to close down review board and start
accepting contributiong through GitHub pull requests. We have been using GH PR for several
months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to
a github PR if you wish. After that time, your patch will no longer be viewable (even though
it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that
using this new process will encourage you to do more.

- Sebastien Goasguen


On Sept. 17, 2014, 12:22 p.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 12:22 p.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its virtual size(root
disk size), admin is facing issues while creating a vm using third party storage plugins like
cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable ismanagedstorage =
true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message