cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 21498: CLOUDSTACK-6009: listHosts API fixed to return all "memory" stats in Bytes instead of a mix of Bytes and Kilobytes
Date Mon, 06 Apr 2015 20:02:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21498/#review79008
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion
on the dev@cloudstack.apache.org the community decided to close down review board and start
accepting contributiong through GitHub pull requests. We have been using GH PR for several
months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to
a github PR if you wish. After that time, your patch will no longer be viewable (even though
it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that
using this new process will encourage you to do more.

- Sebastien Goasguen


On May 15, 2014, 7:54 p.m., Sam Schmit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21498/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 7:54 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6009
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6009
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6009: listHosts API call is returning memoryAvailable and memoryTotal in Bytes,
and memoryUsed in Kilobytes. This fix changes the memoryUsed value to return in Bytes as well,
and includes a new method to return memoryUsed in Kilobytes if needed.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/host/HostStats.java 4eb7b1a 
>   core/src/com/cloud/agent/api/GetHostStatsAnswer.java 6a52e76 
>   core/src/com/cloud/agent/api/HostStatsEntry.java c9d25a0 
> 
> Diff: https://reviews.apache.org/r/21498/diff/
> 
> 
> Testing
> -------
> 
> Pre-change:
> 1)  Called "listHosts" API call with no arguments.
> 2)  Validated that memoryAvailable and memoryTotal were in Bytes, while memoryUsed was
in Kilobytes (factor of 1000 times smaller than it should be)
> 
> Post-change:
> 1)  Called "listHosts" API call with no arguments.
> 2)  Validated that memoryAvailable, memoryTotal, and memoryUsed are all in Bytes, and
memoryAvailable + memoryUsed = memoryTotal
> 
> 
> Thanks,
> 
> Sam Schmit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message