cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC
Date Mon, 06 Apr 2015 20:00:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18795/#review79002
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion
on the dev@cloudstack.apache.org the community decided to close down review board and start
accepting contributiong through GitHub pull requests. We have been using GH PR for several
months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to
a github PR if you wish. After that time, your patch will no longer be viewable (even though
it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that
using this new process will encourage you to do more.

- Sebastien Goasguen


On March 5, 2014, 8:20 p.m., Karl Harris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18795/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 8:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Changes/additions to BASH scripts and .java files as well as pseudo code comments. This
posting is a sanity check review posting; before I get too far along with making the changes
required for this JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC I
thought I'd publish my intentions to the community to review and comment.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1

>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
03af0da51b1eec93eb878fd1ebeca2ff2e0802ce 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
69b7c9e07c753c0f0c93197a809acfb3399cf555 
>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh e5da2e096b30f6fdb15226e889517537d04f2e3e

> 
> Diff: https://reviews.apache.org/r/18795/diff/
> 
> 
> Testing
> -------
> 
> None, yet still coding
> 
> 
> Thanks,
> 
> Karl Harris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message