Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: domain of fozzielumpkins@gmail.com
 designates 209.85.212.171 as permitted sender)
Sender: Funs Kessen <fozzielumpkins@gmail.com>
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\))
Subject: Re: OVM3 test failures
From: Funs Kessen <funs@barred.org>
In-Reply-To: 
 <CAGQtxvbPVHHYHoMuyVEdfOj4KspqnLygGSYq5Jb1F5vAdADbCA@mail.gmail.com>
Date: Fri, 27 Mar 2015 12:20:44 +0100
Cc: Roger Crerie <roger.crerie@hds.com>,
 dev <dev@cloudstack.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <947E9459-F495-473E-BD0C-14E463BFC8EC@barred.org>
References: <B0F07F436C1ABD429CBA289BC54905D34212C325@USINDEM103.corp.hds.com>
 <CAGQtxvY-8xWDLtwqhF7rz2-WbYZGQL50sSFuk3uMf9KsnvTARw@mail.gmail.com>
 <B0F07F436C1ABD429CBA289BC54905D34212C40C@USINDEM103.corp.hds.com>
 <CAGQtxvYckW9+OKX24PEsng3cgREWO8z=-ZqV7R-NUjgkDBPn-g@mail.gmail.com>
 <B0F07F436C1ABD429CBA289BC54905D34212C472@USINDEM103.corp.hds.com>
 <B0F07F436C1ABD429CBA289BC54905D34212C4B4@USINDEM103.corp.hds.com>
 <B0F07F436C1ABD429CBA289BC54905D34212C557@USINDEM103.corp.hds.com>
 <CAGQtxvaak+ZXNCLUEY7wT9qOtUUvsGs1z10mqS++a4LhzyWrrg@mail.gmail.com>
 <B0F07F436C1ABD429CBA289BC54905D34212C59B@USINDEM103.corp.hds.com>
 <CAGQtxvZSyXKm5OA=mohiKROW5+H45hwQF+hwQxhub3b50iUgKA@mail.gmail.com>
 <4A5E6710-8B84-43F2-BF67-D7052F2ED278@barred.org>
 <CAGQtxvYH21Kd=M9C6cp7jAtE9Pyrog12DkL6Zvj_Qk3ysMmsQw@mail.gmail.com>
 <93115E50-F144-4745-B380-5436C26157A6@barred.org>
 <EEDE6097-4A29-4A33-80EF-F20D21CF4038@barred.org>
 <CAGQtxvaEMSAy_0t_1jcn=moaa3bRYSj7p6BNp0JGNxU-Fv930A@mail.gmail.com>
 <5B93CF83-B579-4A82-BE7F-234E506DF7BF@barred.org>
 <CAGQtxvbPVHHYHoMuyVEdfOj4KspqnLygGSYq5Jb1F5vAdADbCA@mail.gmail.com>
To: Daan Hoogland <daan.hoogland@gmail.com>

Nah you are smart enough, it=E2=80=99s just that I was lazy and did a =
search and replace and then noticed I broke something and fixed it with =
another commit.

thanks!

> On 27 Mar 2015, at 12:12, Daan Hoogland <daan.hoogland@gmail.com> =
wrote:
>=20
> /me not being smart enough to use pull requests.
>=20
> I am pulling it now.
>=20
> On Fri, Mar 27, 2015 at 12:04 PM, Funs Kessen <funs@barred.org> wrote:
>> Hi Daan,
>>=20
>>> On 27 Mar 2015, at 11:58, Daan Hoogland <daan.hoogland@gmail.com> =
wrote:
>>>=20
>>> Funs, I commented on it, I think it has a typo in it.
>>> Roger, can you apply that patch and test (after looking at my =
comment)?
>>=20
>> I replied to you, that=E2=80=99s why the pull request contains two =
commit IDs ;)
>>=20
>>>=20
>>> On Fri, Mar 27, 2015 at 11:33 AM, Funs Kessen <funs@barred.org> =
wrote:
>>>> Hi Daan,
>>>>=20
>>>> Had a fix ready yesterday, but after having slept on it, I crushed =
the fix as it was wrong. I=E2=80=99ve fixed it by setting the separator =
hard, and not to File.separator.
>>>>=20
>>>> The logic behind is that the Agent runs on Linux and not on Windows =
so using File.separator will just break things instead of making it =
work, as the code should not be platform independent but specifically =
for the Agent.
>>>>=20
>>>> I=E2=80=99ve got pull request #133 open which should resolve the =
issues on Windows.
>>>>=20
>>>> Cheers,
>>>>=20
>>>> Funs
>>>>=20
>>>>> On 26 Mar 2015, at 21:53, Funs Kessen <funs@barred.org> wrote:
>>>>>=20
>>>>>=20
>>>>>> On 26 Mar 2015, at 21:41, Daan Hoogland <daan.hoogland@gmail.com> =
wrote:
>>>>>>=20
>>>>>> On Thu, Mar 26, 2015 at 9:35 PM, Funs Kessen <funs@barred.org> =
wrote:
>>>>>>> Hi Roger/Daan,
>>>>>>>=20
>>>>>>> Sorry for coming late to the party, and my apologies in advance!
>>>>>>=20
>>>>>> that's alright, i learned something about cs;)
>>>>>>=20
>>>>> Ditto!! :)
>>>>>=20
>>>>>> ...
>>>>>>> The second part of the booboo is in the tests themselves =
actually as you=E2=80=99ve noticed, so I=E2=80=99ll have to place the =
File.seperator there too in XenTest.java.
>>>>>>>=20
>>>>>>> Thanks for reaching out!
>>>>>>>=20
>>>>>>> @Daan: I can fix it in the ovm3rebase branch so you can pick it =
out ?
>>>>>>=20
>>>>>> yeah, that or send me a patch
>>>>>>=20
>>>>> I=E2=80=99ll get you a patch asap, want to make sure I don=E2=80=99t=
 have to make two =3D)
>>>>>=20
>>>>>> Don't forget I added to the misery myself by adding
>>>>>> a4c23b170e4c94d4ed4783b19a051ad8f6c45328
>>>>>>=20
>>>>> "My friend of misery" ?
>>>>>=20
>>>>> =E2=80=94
>>>>>     =3DFuns
>>>>=20
>>>> =E2=80=94
>>>>       =3DFuns
>>>>=20
>>>=20
>>>=20
>>>=20
>>> --
>>> Daan
>>>=20
>>=20
>> =E2=80=94
>>        =3DFuns
>>=20
>=20
>=20
>=20
> --=20
> Daan
>=20

=E2=80=94=20
	=3DFuns