Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-114-cloudstack@git.apache.org>
In-Reply-To: <git-pr-114-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Fix the bug when build apidoc under
 windo...
Content-Type: text/plain
Message-Id: <20150312111704.DA6F1E0A4E@git1-us-west.apache.org>
Date: Thu, 12 Mar 2015 11:17:04 +0000 (UTC)

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/114#discussion_r26293610
  
    --- Diff: tools/apidoc/build-apidoc.sh ---
    @@ -62,7 +62,18 @@ set -e
      sed -e 's,%API_HEADER%,Root Admin API,g' "$thisdir/generatetoc_header.xsl" >generatetocforadmin.xsl
      sed -e 's,%API_HEADER%,Domain Admin API,g' "$thisdir/generatetoc_header.xsl" >generatetocfordomainadmin.xsl
     
    - python "$thisdir/gen_toc.py" $(find . -type f)
    + WINOS=`uname -s|grep -i WIN`
    + gen_toc_file=''
    + if [ "x$WINOS" != "x" ]; then
    + gen_toc_file="`cygpath -w $thisdir`\\gen_toc.py"
    + else
    + gen_toc_file="$thisdir/gen_toc.py"
    + fi
    + 
    + argfiles=`find . -type f`
    --- End diff --
    
    Instead of looping on the found files (argfiles), you can simply give pass it to gen_toc_file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---