cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raja Pullela <raja.pull...@citrix.com>
Subject RE: [DISCUSS] Stop using Review Board
Date Mon, 30 Mar 2015 10:28:24 GMT
+1 for GitHub...

Some of us are already using GH and any new review requests on RB, reviewers should ask for
the owners to post them to GH.
Otherwise, there is no easy way to stop people from using RB ?  

-----Original Message-----
From: Sebastien Goasguen [mailto:runseb@gmail.com] 
Sent: Monday, March 30, 2015 12:52 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Stop using Review Board


> On Mar 30, 2015, at 7:39 AM, Kishan Kavala <Kishan.Kavala@citrix.com> wrote:
> 
> +1 for GitHub
> 
> Can we do a one-time migration of all open RB requests to GH and make RB read-only?
> 

I don’t think we can do an automatic migration. We should all check RB in the coming days,
try to close the one we can and contact the authors we know.

I would like to keep this DISCUSS open till next friday, since it’s a relatively big change.
At that time, I will check with infra if we can make RB read only.


> -----Original Message-----
> From: Rajani Karuturi [mailto:rajani@apache.org]
> Sent: Monday, March 30, 2015 10:33 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Stop using Review Board
> 
> +1
> 
> ~Rajani
> 
> On Fri, Mar 27, 2015 at 9:00 PM, Mike Tutkowski < mike.tutkowski@solidfire.com>
wrote:
> 
>> +1
>> 
>> On Fri, Mar 27, 2015 at 2:52 AM, Sebastien Goasguen 
>> <runseb@gmail.com>
>> wrote:
>> 
>>> Hi everyone,
>>> 
>>> Since GitHub pull requests have been enabled for cloudstack, we have 
>>> closed 127 commits.
>>> 
>>> I believe this is a nicer interface, one that folks are used to when 
>>> contributing to other open source projects.
>>> 
>>> In the meantime, we still have 73 open reviews on Review Board
>>> 
>>> https://reviews.apache.org/
>>> 
>>> * I propose that we stop using RB all together, and remove any links 
>>> to
>> it
>>> from our website and README.
>>> 
>>> A few of us have tried to close some of the reviews by pinging the
>> authors
>>> already.
>>> 
>>> * My second proposition is that we write a comment in all reviews:
>>> 
>>> “Thanks for the patch, the cloudstack community has decided to stop 
>>> using Review Board in favor of github pull request.
>>> You can see <link> to learn how to submit a pull request to cloudstack.
>>> Could you move your patch to a PR ?
>>> Without response from you we will close this review within 7 days.
>>> "
>>> 
>>> There is good contribution guidelines in our docs README:
>>> https://github.com/apache/cloudstack-docs
>>> 
>>> -Sebastien
>> 
>> 
>> 
>> 
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> <http://solidfire.com/solution/overview/?video=play>*™*
>> 

Mime
View raw message