cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nux! <...@li.nux.ro>
Subject Re: Root disk size support in UI - problem with instanceWizard.js
Date Wed, 18 Mar 2015 19:34:02 GMT
Marcus,

Thanks, after gzipping it I can see the field!

Why are we doing this?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

----- Original Message -----
> From: "Marcus" <shadowsor@gmail.com>
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 18 March, 2015 18:55:08
> Subject: Re: Root disk size support in UI - problem with instanceWizard.js

> for 4.5, you'll need to gzip any js files after editing them. At least
> that's what I've observed. You should see a .js and a .js.gz for each.
> 
> On Wed, Mar 18, 2015 at 11:44 AM, Nux! <nux@li.nux.ro> wrote:
>> Thanks Ian, tried your suggestions, but to no effect that I can observe.
>> The root disk field does not appear on the instance creation page.
>>
>> Lucian
>>
>> --
>> Sent from the Delta quadrant using Borg technology!
>>
>> Nux!
>> www.nux.ro
>>
>> ----- Original Message -----
>>> From: "Ian Duffy" <ian@ianduffy.ie>
>>> To: "CloudStack Dev" <dev@cloudstack.apache.org>
>>> Sent: Wednesday, 18 March, 2015 16:52:30
>>> Subject: Re: Root disk size support in UI - problem with instanceWizard.js
>>
>>> Hey Nux,
>>>
>>> This is completely untested and based of reading the source code.
>>>
>>> Within ui/scripts/ui-custom/instanceWizard.js on line ~ 424 you should
>>> find a call to the custom hidden function which determines whether or
>>> not to set display = none on the root resize box.
>>>
>>> Within the ui/scripts/instanceWizard.js you'll see that the root
>>> resize is applied if its element isn't set to display none.
>>>
>>> I'd suggest just setting var custom = false; as a quick and easy fix.
>>>
>>> https://github.com/apache/cloudstack/blob/master/ui/scripts/ui-custom/instanceWizard.js#L424-437
>>>
>>>
>>> On 18 March 2015 at 16:25, Nux! <nux@li.nux.ro> wrote:
>>>> Hello,
>>>>
>>>> In my 4.4.1 install I can use this patch[1] to specify a custom root disk
size
>>>> for an instance[2]. This is of course very handy, enabled me to get rid of
tens
>>>> of templates with custom sizes.
>>>> In 4.5 this patch no longer does it's job, there is no Root Disk field appearing
>>>> during instance creation.
>>>>
>>>> Can anyone have a look?
>>>>
>>>> [1]
>>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=ui/scripts/instanceWizard.js;h=4a740c6685e05449290f1fe378add9a6c71f96ad;hp=646ffbf5b1922fc618bb3ad0091fe15895c24226;hb=8fec09ba481fbd3b8c2a9e4d31ef06f113b037cb;hpb=c1af92fcbbc183873d6519f0660b68acfb33bd44
>>>> [2] http://img.nux.ro/Fw3-Selection_020.png - This is a KVM only feature
for now
>>>>
>>>> --
>>>> Sent from the Delta quadrant using Borg technology!
>>>>
>>>> Nux!
> >> > www.nux.ro

Mime
View raw message