cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "suresh sadhu" <mailtosa...@gmail.com>
Subject Re: Review Request 30661: LDAP:automation:added missing scenrio and additional checks for better debugging
Date Thu, 26 Mar 2015 12:53:14 GMT


> On Feb. 13, 2015, 7:31 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_ldap.py, line 82
> > <https://reviews.apache.org/r/30661/diff/1/?file=850400#file850400line82>
> >
> >     It is better to skip the test when there are no required fields.

initially though to skip the tests  in setup class it self but later realized if it fail to
address the negative scenario so removed the skip test part.


- suresh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30661/#review72341
-----------------------------------------------------------


On Feb. 19, 2015, 12:04 p.m., suresh sadhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30661/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 12:04 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8218
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8218
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added missing scenrio and additional checks for better debugging
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ldap.py 3464022 
> 
> Diff: https://reviews.apache.org/r/30661/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> suresh sadhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message