cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravaradhye <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8380: Adding automation test c...
Date Thu, 19 Mar 2015 12:16:06 GMT
Github user gauravaradhye commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/117#discussion_r26748249
  
    --- Diff: tools/marvin/marvin/lib/common.py ---
    @@ -1395,3 +1399,199 @@ def isNetworkDeleted(apiclient, networkid, timeout=600):
             time.sleep(60)
         #end while
         return networkDeleted
    +
    +
    +def createChecksum(self, virtual_machine, disk, disk_type):
    --- End diff --
    
    Please pass explicit parameters to function than passing self object. It's always good
to pass explicit parameters than wrapping the parameters in big object. It also enhances the
function definition so that to improve readability of the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message