cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vincentbernat <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...
Date Tue, 10 Mar 2015 10:53:49 GMT
Github user vincentbernat commented on the pull request:
    Some remarks:
     - Use `with lock:` instead of `lock.acquire()` then `try/finally` (compatible with Python
     - Use `with file(...) as f:` (idem)
     - `global passMap` and `global lock` are useless since you don't do direct assignments
     - `getPassword()` could be `passMap.get(..., None)`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message