Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B39F510A53 for ; Mon, 16 Feb 2015 12:07:37 +0000 (UTC) Received: (qmail 35655 invoked by uid 500); 16 Feb 2015 12:07:03 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 35603 invoked by uid 500); 16 Feb 2015 12:07:03 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 35585 invoked by uid 99); 16 Feb 2015 12:07:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2015 12:07:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 961461CDD13; Mon, 16 Feb 2015 12:07:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6985003092741262412==" MIME-Version: 1.0 Subject: Review Request 31081: CLOUDSTACK-8257: test_iso.py - Removed assertion on Iso name when random character s are appended to test data before creating Iso From: "Gaurav Aradhye" To: "SrikanteswaraRao Talluri" Cc: "Gaurav Aradhye" , "cloudstack" Date: Mon, 16 Feb 2015 12:07:01 -0000 Message-ID: <20150216120701.21353.28972@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Gaurav Aradhye" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/31081/ X-Sender: "Gaurav Aradhye" Reply-To: "Gaurav Aradhye" X-ReviewRequest-Repository: cloudstack-git --===============6985003092741262412== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31081/ ----------------------------------------------------------- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8258 https://issues.apache.org/jira/browse/CLOUDSTACK-8258 Repository: cloudstack-git Description ------- Create method in Class Iso in base library now appends random characters (6) to the Iso name passed from test data so that each Iso created through test case has different name. Hence assertios based on Iso name should be removed from test case as they won't hold true anymore (Iso name will not match with that passed through the test data). Other changes: 1. Pep8 fixes 2. Import fixes 3. Removing white-spaces 4. Removing unused variables Diffs ----- test/integration/smoke/test_iso.py 4bd66b5 Diff: https://reviews.apache.org/r/31081/diff/ Testing ------- Yes. One test case failed in downloading Iso due to DNS issue in the setup. Otherwise should pass. The test case which failed in BVT build passed in my testing. Thanks, Gaurav Aradhye --===============6985003092741262412==--