Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C11CA179C5 for ; Tue, 3 Feb 2015 10:22:24 +0000 (UTC) Received: (qmail 4916 invoked by uid 500); 3 Feb 2015 10:22:25 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 4867 invoked by uid 500); 3 Feb 2015 10:22:25 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 4829 invoked by uid 99); 3 Feb 2015 10:22:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 10:22:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 39ED31CAC23; Tue, 3 Feb 2015 10:22:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1674969052178001133==" MIME-Version: 1.0 Subject: Re: Review Request 30553: A new script to test_hosts and added update modules for few classes in base.py From: "SrikanteswaraRao Talluri" To: "sanjeev n" , "SrikanteswaraRao Talluri" Cc: "abhinav roy" , "cloudstack" Date: Tue, 03 Feb 2015 10:22:22 -0000 Message-ID: <20150203102222.32500.26760@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "SrikanteswaraRao Talluri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/30553/ X-Sender: "SrikanteswaraRao Talluri" References: <20150203092152.30543.17865@reviews.apache.org> In-Reply-To: <20150203092152.30543.17865@reviews.apache.org> Reply-To: "SrikanteswaraRao Talluri" X-ReviewRequest-Repository: cloudstack-git --===============1674969052178001133== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30553/#review70726 ----------------------------------------------------------- test/integration/component/test_escalations_hosts.py Isn't this redundant? test/integration/component/test_escalations_hosts.py you can make use of cls.apiclient here too instead of getting again in cls.api_client test/integration/component/test_escalations_hosts.py setupClass has the same code to get cls.testdata, you can reuse that here. test/integration/component/test_escalations_hosts.py If you intend to maintain 'cleanup' list for each test, you need not want to initialize in setupClass() line 56 test/integration/component/test_escalations_hosts.py I assume that you don't want to have update_host as a test, hence, @attr decorator doesn't make sense here. Please remove that. test/integration/component/test_escalations_hosts.py you can return "SUCCESS" or "FAILURE" based on the state of the resource. test/integration/component/test_escalations_hosts.py same as above comment test/integration/component/test_escalations_hosts.py same as above comment test/integration/component/test_escalations_hosts.py assertEqual and others are used to determine the result of a testcase, hence, it is not appropriate to use them here inside the helper functions. Have a proper return statements for these helper functions and check them inside the test case to determine the expected output of the test. test/integration/component/test_escalations_hosts.py same as above comment test/integration/component/test_escalations_hosts.py same as above comment - SrikanteswaraRao Talluri On Feb. 3, 2015, 9:21 a.m., abhinav roy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30553/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 9:21 a.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > ------- > > This Patch has following changes : > > 1. A new script to test host status after enabling/disabling of Pods, Clusters, Zones or by managing/unmanaging of clusters etc. > > 2. "update" Modules added for Pod, Zone, cluster classes in base.py > > > Diffs > ----- > > test/integration/component/test_escalations_hosts.py PRE-CREATION > tools/marvin/marvin/lib/base.py e38c394 > > Diff: https://reviews.apache.org/r/30553/diff/ > > > Testing > ------- > > Disable the host and it's cluster, ... === TestName: test_01_op_host_capacity_disable_cluster | Status : SUCCESS === > ok > Disable the host and it's pod, ... === TestName: test_02_op_host_capacity_disable_pod | Status : SUCCESS === > ok > Disable the host and it's zone, ... === TestName: test_03_op_host_capacity_disable_zone | Status : SUCCESS === > ok > Disable the host then unmanage the cluster, ... === TestName: test_04_disable_host_unmanage_cluster_check_hosts_status | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 4 tests in 126.360s > > > Thanks, > > abhinav roy > > --===============1674969052178001133==--