cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 31108: CLOUDSTACK-8261: test_haproxy.py - Remove the code checking AppCookle and LbCookie Stickiness policies
Date Tue, 17 Feb 2015 13:31:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31108/#review72706
-----------------------------------------------------------

Ship it!


e768d702cb4edbf544805de6bb79854c5c55289a master

- SrikanteswaraRao Talluri


On Feb. 17, 2015, 11:56 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31108/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 11:56 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8261
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8261
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The code checks the AppCookie and LbCookie Stickiness policies by doing SSH to VM. This
is wrong because these policies are for HTTP requests.
> 
> Removing the wrong code. We need to device a way to verify these policies through test
case. Added TODO comments for these. Will address them in separate patch.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_haproxy.py 73257e6 
> 
> Diff: https://reviews.apache.org/r/31108/diff/
> 
> 
> Testing
> -------
> 
> Test Configure stickiness policies with default values ... === TestName: test_01_create_sticky_policy_default_values
| Status :
> SUCCESS ===
> ok
> Test Configure stickiness policies with custom values ... === TestName: test_02_create_sticky_policy_custom_values
| Status :
> SUCCESS ===
> ok
> Test listnetworks response to check supported stickiness policies ... === TestName: test_03_supported_policies_by_network
|
> Status : SUCCESS ===
> ok
> Test LB rule before/after stickiness policy creation ... === TestName: test_04_delete_lb_rule
| Status : SUCCESS ===
> ok
> Test error/alerts after creating stickiness policy ... === TestName: test_05_error_alerts_after_create
| Status : SUCCESS ===
> ok
> Test release public IP with stickiness policy ... === TestName: test_06_release_ip |
Status : SUCCESS ===
> ok
> Test Delete account  and check the router and its rules ... === TestName: test_07_delete_account
| Status : SUCCESS ===
> ok
> Test verify create stickiness policy when router is stopped state ... === TestName: test_08_create_policy_router_stopped
|
> Status : SUCCESS ===
> ok
> Test check the stickiness policy rules after destroying router ... === TestName: test_09_create_policy_router_destroy
| Status :
> SUCCESS ===
> ok
> Test enable/disable the VPN after applying sticky policy rules ... === TestName: test_10_create_policy_enable_disable_vpn
|
> Status : SUCCESS ===
> ok
> Test verfify functionality syncronous and asyncronous validations ... === TestName: test_11_invalid_params
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 11 tests in 3133.053s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message