cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 30990: CLOUDSTACK-8255: Adding secondary IP to correct ethernet interface present on the VM
Date Fri, 13 Feb 2015 12:39:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30990/#review72360
-----------------------------------------------------------

Ship it!


e66ceaa254b21b3b365ade0682470bffa48c15b4 master

- SrikanteswaraRao Talluri


On Feb. 13, 2015, 11:49 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30990/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 11:49 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8255
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In test_lb_secondary_ip.py test cases, secondary ip is added to eth0 interface. However
in some of the VMs, this interface is absent and eth2 is present.
> 
> It is wise to list the ethernet interface first, and then use the ethernet interface
present on the VM to add the secondary IP to, rather than hard coding the name of the ethernet
interface.
> 
> Other change:
> Use high end service offering for Hyperv VMs
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_lb_secondary_ip.py ecf0985 
> 
> Diff: https://reviews.apache.org/r/30990/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested the SSH test cases.
> 
> SSH to VM using LB rule assigned to secondary IP of VM ... === TestName: test_11_ssh_to_secondary_ip
| Status : SUCCESS ===
> ok
> SSH to VM using LB rule assigned to primary and secondary IP of VM ... SKIP: Failing-WIP
> SSH to VM after deleting LB rule ... === TestName: test_13_delete_lb_rule | Status :
SUCCESS ===
> ok
> ssh to vm after removing secondary ip from load balancer rule ... SKIP: Skip
> ssh to vm after removing secondary ip from load balancer rule ... === TestName: test_15_remove_lb_rule_primary_ip
| Status : SUCCESS
> ===
> ok
> ssh to vm after removing secondary ip from load balancer rule ... === TestName: test_16_delete_vm_from_lb_rule
| Status : SUCCESS ===
> ok
> Verify LB rules after destroying and recovering VM ... === TestName: test_20_destroy_recover_vm
| Status : SUCCESS ===
> ok
> Verify LB rule functioning with different algorithm ... === TestName: test_21_modify_lb_rule_algorithm
| Status : SUCCESS ===
> ok
> 
> 
> ----------------------------------------------------------------------
> Ran 19 tests in 2922.113s
> 
> OK (SKIP=14)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message