cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 30967: CLOUDSTACK-8253: Code correction and improvement: test_haproxy.py
Date Fri, 13 Feb 2015 07:07:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30967/#review72335
-----------------------------------------------------------

Ship it!


d849a66b47e81e9da234af0ba376327d626462dc master

- SrikanteswaraRao Talluri


On Feb. 13, 2015, 6:17 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30967/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 6:17 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8253
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8253
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_haproxy.py is using the config data included in the test file itself, however it
should consume the data from test_data.py file.
> 
> Also the code is testing LB rule stickiness policies but there is an extra NAT rule present
for the same IP addresses which prevents the test case from testing the Stickiness policies
alone.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_haproxy.py e941e5b 
> 
> Diff: https://reviews.apache.org/r/30967/diff/
> 
> 
> Testing
> -------
> 
> Currently failing for Stickiness policies AppCookie and LbCookie.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message