cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 30660: CLOUDSTACK-8219: Marvin: Correct code related to getting free vlan in the setup
Date Thu, 05 Feb 2015 10:56:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30660/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8219
    https://issues.apache.org/jira/browse/CLOUDSTACK-8219


Repository: cloudstack-git


Description
-------

The function "get_free_vlan" lists all the networks in the setup and generates a vlan in the
physical vlan range which is not used by any of the listed networks.

However the method lists only shared networks. It should list all the networks so that the
vlan does not overlap with any of the used vlans.


Diffs
-----

  tools/marvin/marvin/lib/common.py 28ec024 

Diff: https://reviews.apache.org/r/30660/diff/


Testing
-------

Yes.

Test Shared Network ALL ... === TestName: test_createSharedNetwork_All | Status : SUCCESS
===
ok
Test Shared Network with scope account ... === TestName: test_createSharedNetwork_accountSpecific
| Status : SUCCESS ===
ok
Test Shared Network with scope domain ... === TestName: test_createSharedNetwork_domainSpecific
| Status : SUCCESS ===
ok


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message