cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
Date Thu, 05 Feb 2015 08:59:03 GMT


> On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 774
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line774>
> >
> >     I cant make out how and what are you trying to veirfy in such type of assert
. 
> >     
> >     For example in this case usagetype 6 will be generated for all the root and
data volume created till now in the test suite then how  will this assert help anyway ?

This assert checks that there is no exception thrown while listing usage records. If there
is any exception, then FAIL will be returned from self.listUsageRecords function and based
on PASS/FAIL, exceptin will thrown by the assert.

If the response is PASS, then only we proceed with checking the usage records.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71180
-----------------------------------------------------------


On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 12:24 p.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7911
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7911
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
> 
> 
> Diffs
> -----
> 
>   test/integration/testpaths/testpath_usage.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d5ed353 
>   tools/marvin/marvin/dbConnection.py 66c6cb1 
>   tools/marvin/marvin/lib/base.py e38c394 
>   tools/marvin/marvin/lib/utils.py 8788b3b 
> 
> Diff: https://reviews.apache.org/r/28030/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message