cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
Date Wed, 04 Feb 2015 08:51:47 GMT


> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 289
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line289>
> >
> >     when uage server is not installed  follwoing is the output
> >     
> >     service cloudstack-usage status
> >     
> >     cloudstack-usage: unrecognized service
> >      
> >      unknown is still not in the response

I will fix this.


> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 329
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line329>
> >
> >     Sorry i my sound stupid as i am reviewing the code for the first time  but still
can you please explain what is validated over here ?  content of the list ? content of the
list or soemthing else?

It's verifying the list is not empty. (validateList function is present in utils.py file)


> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 402
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line402>
> >
> >     again can you please specify what are you verifying here ?

It verifies the response returned from the function is PASS. if it FAIL, then exception returned
will be thrown by the assert.


> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 405
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line405>
> >
> >     Several other veirfication also need to be done apart from size . 
> >     
> >     First the usage time shown is correct or not. For this we need to get created
time from usage-event table for template create event and then usage job execution time and
calculate time and this time should be equal to the time shown in usage api

Ok, will add this check.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70929
-----------------------------------------------------------


On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 12:24 p.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7911
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7911
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
> 
> 
> Diffs
> -----
> 
>   test/integration/testpaths/testpath_usage.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d5ed353 
>   tools/marvin/marvin/dbConnection.py 66c6cb1 
>   tools/marvin/marvin/lib/base.py e38c394 
>   tools/marvin/marvin/lib/utils.py 8788b3b 
> 
> Diff: https://reviews.apache.org/r/28030/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message