cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 30553: A new script to test_hosts and added update modules for few classes in base.py
Date Tue, 03 Feb 2015 10:22:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30553/#review70726
-----------------------------------------------------------



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116088>

    Isn't this redundant?



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116089>

    you can make use of cls.apiclient here too instead of getting again in cls.api_client



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116090>

    setupClass has the same code to get cls.testdata, you can reuse that here.



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116091>

    If you intend to maintain 'cleanup' list for each test, you need not want to initialize
in setupClass() line 56



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116093>

    I assume that you don't want to have update_host as a test, hence, @attr decorator doesn't
make sense here. Please remove that.



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116098>

    you can return "SUCCESS" or "FAILURE" based on the state of the resource.



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116094>

    same as above comment



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116095>

    same as above comment



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116106>

    assertEqual and others are used to determine the result of a testcase, hence, it is not
appropriate to use them here inside the helper functions. Have a proper return statements
for these helper functions and check them inside the test case to determine the expected output
of the test.



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116096>

    same as above comment



test/integration/component/test_escalations_hosts.py
<https://reviews.apache.org/r/30553/#comment116097>

    same as above comment


- SrikanteswaraRao Talluri


On Feb. 3, 2015, 9:21 a.m., abhinav roy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30553/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 9:21 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This Patch has following changes :
> 
> 1. A new script to test host status after enabling/disabling of Pods, Clusters, Zones
or by managing/unmanaging of clusters etc.
> 
> 2. "update" Modules added for Pod, Zone, cluster classes in base.py
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_hosts.py PRE-CREATION 
>   tools/marvin/marvin/lib/base.py e38c394 
> 
> Diff: https://reviews.apache.org/r/30553/diff/
> 
> 
> Testing
> -------
> 
> Disable the host and it's cluster, ... === TestName: test_01_op_host_capacity_disable_cluster
| Status : SUCCESS ===
> ok
> Disable the host and it's pod, ... === TestName: test_02_op_host_capacity_disable_pod
| Status : SUCCESS ===
> ok
> Disable the host and it's zone, ... === TestName: test_03_op_host_capacity_disable_zone
| Status : SUCCESS ===
> ok
> Disable the host then unmanage the cluster, ... === TestName: test_04_disable_host_unmanage_cluster_check_hosts_status
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 4 tests in 126.360s
> 
> 
> Thanks,
> 
> abhinav roy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message