Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-65-cloudstack@git.apache.org>
In-Reply-To: <git-pr-65-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Use constant-time comparison
 functions wh...
Content-Type: text/plain
Message-Id: <20150114105324.235A0A22FD2@tyr.zones.apache.org>
Date: Wed, 14 Jan 2015 10:53:23 +0000 (UTC)

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/65#discussion_r22929307
  
    --- Diff: server/src/com/cloud/api/ConstantTimeComparator.java ---
    @@ -0,0 +1,36 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package com.cloud.api;
    +
    +public class ConstantTimeComparator {
    +
    +    public static boolean compareBytes(byte[] b1, byte[] b2) {
    +        if (b1.length != b2.length) {
    +            return false;
    +        }
    +
    +        int result = 0;
    +        for (int i = 0; i < b1.length; i++) {
    +            result |= b1[i] ^ b2[i];
    --- End diff --
    
    Neat. +1
    
    I would suggest moving this to utils instead of api. The api directory or artifact should hold only contracts, commands and interfaces, if this is in utils it could be re-usable (or maybe not) in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---