cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus <shadow...@gmail.com>
Subject Re: [VOTE] Apache CloudStack 4.5.0 RC1
Date Tue, 20 Jan 2015 17:02:31 GMT
...or I guess we can just disable extra attributes altogether for
kvmclock, if we can confirm that it never should have had extra
options

On Tue, Jan 20, 2015 at 9:01 AM, Marcus <shadowsor@gmail.com> wrote:
> I'd suggest in LibvirtComputingResource we wrap the call to
> clock.setTimer for kvmclock in a libvirt version check and change the
> parameters passed based on that (see  variable
> _hypervisorLibvirtVersion). I haven't tracked down exactly which
> version shipped it, but it seems like someone was 'cleaning up'
> libvirt and perhaps enforced that kvmclock doesn't take options:
>
> http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=bbd392ff86249434ca63bb5977d2b1bd2d72a538
>
> "- kvmclock: no extra attributes are supported"
>
> In general, we want kvmclock, and it should only be disabled if
> there's an issue (e.g. it has broken live migration in the past with
> certain qemu and kernel versions).
>
> I am confused about one thing, you mention this only shows up when you
> add volumes, correct? Is that attaching a volume to a VM with these
> settings? Is the clock XML somehow getting added to the volume?
>
> On Tue, Jan 20, 2015 at 4:44 AM, Rohit Yadav <rohit.yadav@shapeblue.com> wrote:
>> Hi Marcus,
>>
>> Thanks for replying. I checked the code, we read the config value from
>> agent.properties to see if kvmclock.disabled param is true or false.
>> Based on that only we general suitable xml. I think codewise it looks
>> alright, what other improvements do you think we can do?
>>
>> The libvirt version on my host (Ubuntu 14.04 based) was 1.2.2. I
>> couldn't find after which version of libvirt it should work so as to put
>> a if-else check for that.
>>
>>
>> On Monday 19 January 2015 09:55 PM, Marcus wrote:
>>>
>>> Rohit, the kvmclock error might be that we are trying to use a feature
>>> of kvmclock that is missing in your particular version of qemu or
>>> libvirt. We probably don't want to require kvmclock to be disabled
>>> (though it is an option), so we can perhaps wrap the offending tick
>>> code xml generation in a version check as done elsewhere.
>>>
>>> On Mon, Jan 19, 2015 at 4:30 AM, Daan Hoogland <daan.hoogland@gmail.com>
>>> wrote:
>>>>
>>>> Rohit is mentioning regression here. I suggest we drop this rc.
>>>>
>>>> mobile dev with bilingual spelling checker used (read at your own risk)
>>>> Op 15 jan. 2015 15:42 schreef "Rohit Yadav" <rohit.yadav@shapeblue.com>:
>>>>
>>>>> Hi,
>>>>>
>>>>> Tested using KVM: While it was working for most cases it failed for me
>>>>> (after upgrades from 4.3.2) for few minor issues.
>>>>>
>>>>> Due to this, I've to vote -1.
>>>>>
>>>>> Browsing cluster level settings produced NPE. This issue has already
>>>>> been fixed in 4.4 but somehow did not make in to 4.5/master. I've fixed
>>>>> it on 4.5/master (CLOUDSTACK-7219). No NPE seen after this fix, though
>>>>> it would hide errors in log in case a configuration is found but
>>>>> configDepot return null we get NPE. I'm not sure why this happened for
>>>>> key "cluster.memory.allocated.capacity.disablethreshold"
>>>>>
>>>>> On fresh deployment with KVM, creation of volumes failed with kvmclock
>>>>> related exceptions.
>>>>> 2015-01-15 11:53:01,500 WARN  [kvm.resource.LibvirtComputingResource]
>>>>> (agentRequest-Handler-1:null) LibvirtException
>>>>> org.libvirt.LibvirtException: unsupported configuration: timer kvmclock
>>>>> doesn't support setting of timer tickpolicy
>>>>>          at org.libvirt.ErrorHandler.processError(Unknown Source)
>>>>>
>>>>> This was fixed after setting 'kvmclock.disable=true' in
>>>>> /etc/cloudstack/agent/agent.properties While this worked after this
>>>>> workaround, I want to discuss if this should be treated like a bug?
>>>>>
>>>>> Whenever ssvms were launching some warning and exceptions were seen (in
>>>>> basic zone with or without localstorage) and after this exception
>>>>> CloudStack kept trying to launch them and finally succeeded in deploying
>>>>> systemvms:
>>>>>
>>>>> 2015-01-15 19:32:02,829 WARN  [c.c.u.d.Merovingian2]
>>>>> (Work-Job-Executor-1:ctx-0a56dc80 job-10/job-12 ctx-8e851b7a) Was unable
>>>>> to find lock for the key template_spool_ref1 and thread id 258565260
>>>>> com.cloud.utils.exception.CloudRuntimeException: Was unable to find lock
>>>>> for the key template_spool_ref1 and thread id 258565260
>>>>>>
>>>>>> ---at com.cloud.utils.db.Merovingian2.release(Merovingian2.java:274)
>>>>>
>>>>>
>>>>>> ---at
>>>>>
>>>>> com.cloud.utils.db.TransactionLegacy.release(TransactionLegacy.java:397)
>>>>>>
>>>>>> ---at
>>>>>
>>>>> com.cloud.utils.db.GenericDaoBase.releaseFromLockTable(
>>>>> GenericDaoBase.java:1045)
>>>>>
>>>>> While the above seems something which can be ignored, I don't know why
>>>>> this was happening.
>>>>>
>>>>> What worked on KVM:
>>>>>
>>>>> - Basic zone deployment without and without local storage and
>>>>> with/without security groups (after kvmclock disable fix)
>>>>> - Basic vm lifecycle: create, start, stop, restart, destroy
>>>>> - Upgrade from 4.3.2 after NPE fix
>>>>>
>>>>> I'll test other components in detail tomorrow wrt advance zone, vpc and
>>>>> networking.
>>>>>
>>>>> Regards.
>>>>>
>>>>> On Tuesday 13 January 2015 04:46 AM, David Nalley wrote:
>>>>>
>>>>>> Hi folks,
>>>>>>
>>>>>> I've created a 4.5.0 release candidate, with the following artifacts
>>>>>> up for a vote:
>>>>>>
>>>>>> Git Branch and Commit SH:
>>>>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=
>>>>>> tree;h=refs/heads/4.5-RC20150112T2256;hb=4.5-RC20150112T2256
>>>>>> Commit: 8db3cbd4ff62b17a8b496026b68cf60ee0c76740
>>>>>>
>>>>>> Source release (checksums and signatures are available at the same
>>>>>> location):
>>>>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.5.0-rc1/
>>>>>>
>>>>>> PGP release keys (signed using 6FE50F1C):
>>>>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>>>>>
>>>>>> Vote will be open for at least 72 hours.
>>>>>>
>>>>>> For sanity in tallying the vote, can PMC members please be sure to
>>>>>> indicate "(binding)" with their vote?
>>>>>>
>>>>>> [ ] +1  approve
>>>>>> [ ] +0  no opinion
>>>>>> [ ] -1  disapprove (and reason why)
>>>>>>
>>>>>>
>>>>> --
>>>>> Regards,
>>>>> Rohit Yadav
>>>>> Software Architect, ShapeBlue
>>>>> M. +91 8826230892 | rohit.yadav@shapeblue.com
>>>>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>>>> PS. If you see any footer below, I did not add it :)
>>>>> Find out more about ShapeBlue and our range of CloudStack related
>>>>> services
>>>>>
>>>>> IaaS Cloud Design & Build<http://shapeblue.com/
>>>>> iaas-cloud-design-and-build//>
>>>>> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
>>>>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
>>>>> CloudStack Software
>>>>> Engineering<http://shapeblue.com/cloudstack-software-
>>>>> engineering/>
>>>>> CloudStack Infrastructure Support<http://shapeblue.com/
>>>>> cloudstack-infrastructure-support/>
>>>>> CloudStack Bootcamp Training Courses<http://shapeblue.com/
>>>>> cloudstack-training/>
>>>>>
>>>>> This email and any attachments to it may be confidential and are
>>>>> intended
>>>>> solely for the use of the individual to whom it is addressed. Any views
>>>>> or
>>>>> opinions expressed are solely those of the author and do not necessarily
>>>>> represent those of Shape Blue Ltd or related companies. If you are not
>>>>> the
>>>>> intended recipient of this email, you must neither take any action based
>>>>> upon its contents, nor copy or show it to anyone. Please contact the
>>>>> sender
>>>>> if you believe you have received this email in error. Shape Blue Ltd
is
>>>>> a
>>>>> company incorporated in England & Wales. ShapeBlue Services India
LLP is
>>>>> a
>>>>> company incorporated in India and is operated under license from Shape
>>>>> Blue
>>>>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
>>>>> Brasil
>>>>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd
>>>>> is
>>>>> a company registered by The Republic of South Africa and is traded under
>>>>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>>>>
>>
>> --
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>> M. +91 8826230892 | rohit.yadav@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>> PS. If you see any footer below, I did not add it :)
>> Find out more about ShapeBlue and our range of CloudStack related services
>>
>> IaaS Cloud Design &
>> Build<http://shapeblue.com/iaas-cloud-design-and-build//>
>> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
>> CloudStack Software
>> Engineering<http://shapeblue.com/cloudstack-software-engineering/>
>> CloudStack Infrastructure
>> Support<http://shapeblue.com/cloudstack-infrastructure-support/>
>> CloudStack Bootcamp Training
>> Courses<http://shapeblue.com/cloudstack-training/>
>>
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error. Shape Blue Ltd is a
>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>> company incorporated in India and is operated under license from Shape Blue
>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a
>> company registered by The Republic of South Africa and is traded under
>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Mime
View raw message