Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58DB110AE2 for ; Wed, 24 Dec 2014 09:53:20 +0000 (UTC) Received: (qmail 12347 invoked by uid 500); 24 Dec 2014 09:53:19 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 12303 invoked by uid 500); 24 Dec 2014 09:53:19 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 12281 invoked by uid 99); 24 Dec 2014 09:53:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Dec 2014 09:53:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF7751D20FE; Wed, 24 Dec 2014 09:53:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3524486020533422640==" MIME-Version: 1.0 Subject: Re: Review Request 29363: CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case From: "SrikanteswaraRao Talluri" To: "SrikanteswaraRao Talluri" Cc: "Gaurav Aradhye" , "cloudstack" Date: Wed, 24 Dec 2014 09:53:16 -0000 Message-ID: <20141224095316.10621.85827@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "SrikanteswaraRao Talluri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/29363/ X-Sender: "SrikanteswaraRao Talluri" References: <20141223121300.10620.19276@reviews.apache.org> In-Reply-To: <20141223121300.10620.19276@reviews.apache.org> Reply-To: "SrikanteswaraRao Talluri" X-ReviewRequest-Repository: cloudstack-git --===============3524486020533422640== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29363/#review66021 ----------------------------------------------------------- Ship it! Ship It! - SrikanteswaraRao Talluri On Dec. 23, 2014, 12:13 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29363/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:13 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8116 > https://issues.apache.org/jira/browse/CLOUDSTACK-8116 > > > Repository: cloudstack-git > > > Description > ------- > > Moved ldap data to configurableData section in test_data.py and made related changes in the test case. > Also fixed pep8 issues and imports. > > > Diffs > ----- > > test/integration/component/test_ldap.py 5a78957 > tools/marvin/marvin/config/test_data.py ba2fb24 > > Diff: https://reviews.apache.org/r/29363/diff/ > > > Testing > ------- > > Not tested. Requires ldap server to be setup. The test case will be run successfully when correct information is filled in test_data.py file. > > > Thanks, > > Gaurav Aradhye > > --===============3524486020533422640==--