cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.1
Date Fri, 19 Dec 2014 15:56:55 GMT
On Fri, Dec 19, 2014 at 4:38 PM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:
...

> One question though, is there a known issue with the color coding? it
>>>> seems to change halfway through words in the output and not be
>>>> consistent in the help/error messages. Not a blocker and I may need to
>>>> read more but it looks a bit strange.
>>>>
>>>
>>
>>>
>>> If you running the CLI as a tool on bash (single query like cloudmonkey
>>> list users), no colors are output (say in a bash script) this is to
>>> avoid printing escape chars (for color) which mess up in bash script
>>> (when people try to grep/sed/awk stuff with the output).
>>>
>>
>> I am running interactive
>>
>>
>>> In case colors are enabled then errors are printed in red color if they
>>> start with "Error" string. The color scheme is haphazard for anyone (I
>>> set the colors such that they looked best when using Solarized dark
>>> theme on terminal http://ethanschoonover.com/solarized)
>>>
>>> Please advise on the color behaviour and any improvements we should have?
>>>
>>
>> it is kind of christmassish and I like it but it seems like to have no
>> intention to make sense at all. I am using iTerm2 with no special
>> color configuration.
>> it seems to be all random coloring to me on regular output, see a
>> annotated fragment of output below:
>>
>> ============================================================
>> ====================
>> id = 6afa0b72-8787-11e4-a3e5-964184d18d4f <-- id in red-undelined, '='
>> in grey and value in yellow
>> aclid = 6af9e6f6-8787-11e4-a3e5-964184d18d4f <-- same scheme
>> action = Deny <-- green, light-blue, grey
>> cidrlist = 0.0.0.0/0 <-- cid- in red-underline/-rlist in grey, '='
>> grey, '0.' in lightblue/'0.0.0/0' in grey
>> fordisplay = True
>> number = 1
>> protocol = all
>> state = Active <-- 'Active' in purple
>> tags: <-- red-underline
>> traffictype = Ingress
>>
>> on error output:
>> (local) [image: 🐵] > add host
>> Missing arguments: password hypervisor podid url username zoneid
>>
>> 'password', 'hypervisor' and 'url' are grey, 'username' is green and
>> the rest of the line-elements are red-undelined
>>
>
> That's sort of expected. When I wrote the color output (using Pygments)
> I thought some parts of the output (things like id, uuids, numbers,
> names etc) were more important than others so I gave them different colors.
>
> There are regex rules to decide what color the "key" or value should
> get. It's sort of haphazard indeed (those who are not used to it):
> https://github.com/apache/cloudstack-cloudmonkey/blob/
> master/cloudmonkey/printer.py
>

​Ok, i had a look, it seems the cid-rlist is a victem of the regexps,
kind-of-a-bug.​



>
> I've known this issue since the colors and regex rules are hardcoded in
> above since the early days, I think one solution is to allow people plug
> their color schemes and (regex) rules, perhaps for future versions.
>
>
>
>>
>>  On Fri, Dec 19, 2014 at 12:01 PM, Erik Weber <terbolous@gmail.com>
>>>> wrote:
>>>>
>>>>>
>>>>> On Mon, Dec 15, 2014 at 7:10 AM, Rohit Yadav <bhaisaab@apache.org>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I've created a 5.3.1 release of CloudMonkey, with the following
>>>>>> artifacts
>>>>>> up for a vote:
>>>>>>
>>>>>> Git Branch and Commit SHA:
>>>>>>
>>>>>>
>>>>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack-
>>>>>> cloudmonkey.git;a=shortlog;h=refs/heads/master
>>>>>> Commit: 387f0338f9715f2337a9e10c92d1c76fa5d2a381
>>>>>>
>>>>>> List of changes:
>>>>>>
>>>>>>
>>>>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack-
>>>>>> cloudmonkey.git;a=blob_plain;f=CHANGES.md
>>>>>>
>>>>>> Source release (checksums and signatures are available at the same
>>>>>> location):
>>>>>> https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.3.1/
>>>>>>
>>>>>> PGP release keys (signed using key ID 0EE3D884):
>>>>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>>>>>
>>>>>> Vote will be open for 72 hours.
>>>>>>
>>>>>> For sanity in tallying the vote, can PMC members please be sure to
>>>>>> indicate
>>>>>> "(binding)" with their vote?
>>>>>>
>>>>>> [ ] +1 approve
>>>>>> [ ] +0 no opinion
>>>>>> [ ] -1 disapprove (and reason why)
>>>>>>
>>>>>> Regards.
>>>>>>
>>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>> Testing done:
>>>>>    + Successfully upgraded from 5.3.0 to 5.3.1 on Mac OS X
>>>>>    + Sync works
>>>>>    + Loading profile on the command line (with -p) works
>>>>>    + Using param completion when not at the end of line/string works
>>>>>    + Various daily list/reset/deploy tasks
>>>>>
>>>>>
>>>>> --
>>>>> Erik
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>> --
>>> Regards,
>>> Rohit Yadav
>>> Software Architect, ShapeBlue
>>> M. +91 8826230892 | rohit.yadav@shapeblue.com
>>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>> PS. If you see any footer below, I did not add it :)
>>> Find out more about ShapeBlue and our range of CloudStack related
>>> services
>>>
>>> IaaS Cloud Design &
>>> Build<http://shapeblue.com/iaas-cloud-design-and-build//>
>>> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
>>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
>>> CloudStack Software
>>> Engineering<http://shapeblue.com/cloudstack-software-engineering/>
>>> CloudStack Infrastructure
>>> Support<http://shapeblue.com/cloudstack-infrastructure-support/>
>>> CloudStack Bootcamp Training
>>> Courses<http://shapeblue.com/cloudstack-training/>
>>>
>>> This email and any attachments to it may be confidential and are intended
>>> solely for the use of the individual to whom it is addressed. Any views
>>> or
>>> opinions expressed are solely those of the author and do not necessarily
>>> represent those of Shape Blue Ltd or related companies. If you are not
>>> the
>>> intended recipient of this email, you must neither take any action based
>>> upon its contents, nor copy or show it to anyone. Please contact the
>>> sender
>>> if you believe you have received this email in error. Shape Blue Ltd is a
>>> company incorporated in England & Wales. ShapeBlue Services India LLP is
>>> a
>>> company incorporated in India and is operated under license from Shape
>>> Blue
>>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
>>> Brasil
>>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd
>>> is a
>>> company registered by The Republic of South Africa and is traded under
>>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>>
>>
>>
>>
>>
> --
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +91 8826230892 | rohit.yadav@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
> PS. If you see any footer below, I did not add it :)
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<http://shapeblue.com/
> iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
> CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-
> engineering/>
> CloudStack Infrastructure Support<http://shapeblue.com/
> cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<http://shapeblue.com/
> cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>


-- 
Daan

Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message