cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 29144: CLOUDSTACK-8081: Fixed VM snapshot test cases in test_escalation_instances.py and also dealt cleanup issues
Date Wed, 17 Dec 2014 13:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29144/#review65313
-----------------------------------------------------------

Ship it!


daabe92a992f072c6305b14b88fcda99e19a7190 4.5
6674f95cdd268652d109558eabb3402a4e6f7e43 master

- SrikanteswaraRao Talluri


On Dec. 17, 2014, 6:09 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29144/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 6:09 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8081
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8081
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The VM snapshot test case was failiong while reverting the snapshot. That is because
the VM snapshot created included only the disk, not memory. And reverting a VM snapshot having
only disk is possible only when the VM is in stopped state.
> 
> So either stop the VM before reverting the snapshot, or inlude memory too while creating
the VM snapshot.
> 
> Changes:
> 1) Included memory while creating VM snapshot.
> 2) Created separate account for each test case rather than using common account (Common
account might leads to cleanup complexities, where the test cases affect each other)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 9f053a1 
> 
> Diff: https://reviews.apache.org/r/29144/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message