cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 28748: CLOUDSTACK-8021: Change test cases to use host information from configurableData section in test_data.py
Date Fri, 12 Dec 2014 07:25:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28748/
-----------------------------------------------------------

(Updated Dec. 12, 2014, 12:55 p.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
-------

Added rebased patch for 4.5


Bugs: CLOUDSTACK-8021
    https://issues.apache.org/jira/browse/CLOUDSTACK-8021


Repository: cloudstack-git


Description
-------

Changing few test cases to use the host username, password from the configurableData section
in test_data.py. Earlier they were reading the hard coded value. Removed old host_password
value from test_data.py

Also fixed few pep8 issues.


Diffs
-----

  test/integration/component/test_deploy_vgpu_vm.py 0284eab 
  test/integration/component/test_persistent_networks.py 4b1bc7a 
  test/integration/smoke/test_deploy_vgpu_enabled_vm.py f13ac92 

Diff: https://reviews.apache.org/r/28748/diff/


Testing
-------

Tested test_persistent_networks.py
Other test cases not testable right now. Change is only in reading the config value.


File Attachments (updated)
----------------

0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch
  https://reviews.apache.org/media/uploaded/files/2014/12/12/c34be7cc-b1f2-4f6e-8146-1788f7070d6c__0001-CLOUDSTACK-8021-Change-test-cases-to-use-host-inform.patch


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message