cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Axel Delahaye" <axel.delah...@worldline.com>
Subject Re: Review Request 20078: console-proxy add support of AltGr key and FR azerty keyboard
Date Mon, 08 Dec 2014 10:30:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20078/
-----------------------------------------------------------

(Updated déc. 8, 2014, 10:30 matin)


Review request for cloudstack, Anshul Gangwar, Brian Federle, Chiradeep Vittal, Jessica Wang,
and Sanjay Tripathi.


Changes
-------

tested on master with : git am <patch>


Repository: cloudstack-git


Description
-------

(Port of https://reviews.apache.org/r/16688/ to master branch)

Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
altgr : <altgr state match condition>, -- match on altgr state

It works like the shift match condition.
shift : <shift state match condition>, -- match on shift state

Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr'
condition will be true.

In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key

Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character
(like #{}[]|,etc.)

For example the '#':

{keycode: 51, entry: [         //User type the "3# key and each condition match 'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true},   //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true},     //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true}    //release the AltGr key
]},

Thanks for watching my work

Axel Delahaye


Diffs (updated)
-----

  services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java fc3bf4b

  systemvm/css/ajaxviewer.css fd2fb3c 
  systemvm/js/ajaxkeys.js 3053b7d 
  systemvm/js/ajaxviewer.js db5ed45 

Diff: https://reviews.apache.org/r/20078/diff/


Testing
-------

Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc


Thanks,

Axel Delahaye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message