cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimRots <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...
Date Sun, 07 Dec 2014 17:05:38 GMT
Github user TimRots commented on the pull request:

    https://github.com/apache/cloudstack/pull/10#issuecomment-65944285
  
    Hi Rohit,
    
    >What does this PR do?
    Fix bad practice demonstration
    
    >What is the issue and what does this fix do?
    The main method demonstrates bad-practice, pre-PullRequest a fixed
    Initialization Vector was used in this method for generating AES key in CBC
    mode. This weakens the strength of the outcome and should be avoided at all
    times imho.
    
    >his is same as #11 <https://github.com/apache/cloudstack/pull/11> please
    close one of them.
    Correct, same file used at different location in the CS project.
    
    Kind regards
    
    2014-12-05 18:26 GMT+01:00 Rohit Yadav <notifications@github.com>:
    
    > What does this PR do? What is the issue and what does this fix do?
    > This is same as #11 <https://github.com/apache/cloudstack/pull/11> please
    > close one of them. Thanks.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/10#issuecomment-65823752>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message