cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE
Date Fri, 05 Dec 2014 18:34:37 GMT


> On Dec. 5, 2014, 6:03 p.m., Rohit Yadav wrote:
> > Hey Laszlo, that's a nice feature please advise if you want to submit a tested patch
that applies on master or you want to close it?
> > Thanks.
> 
> Laszlo Hornyak wrote:
>     Hi Rohit,
>     
>     I plan to finish all tests in the next few weeks/days and send a fully tested version,
however we can use github for the reviews, so I will just close this for now.
>     
>     Thank you,
>     Laszlo

Great!


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review64025
-----------------------------------------------------------


On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 6:13 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  - use the User-Agent header to get the client type
>  - only use the cache workaround if the browser is MSIE, use standard cache control headers
anyway
> 
> 
> Diffs
> -----
> 
>   ui/index.jsp 5840e71 
>   utils/pom.xml cc6de3b 
>   utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION 
>   utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20343/diff/
> 
> 
> Testing
> -------
> 
> -unit testing
> -tests with firefox
> - tests with IE
> - tests with modified files
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message