cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 28741: CLOUDSTACK-8018: Improve code quality - test_redundant_router.py
Date Fri, 05 Dec 2014 14:38:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28741/#review63995
-----------------------------------------------------------


pushed to 4.5 too.

- SrikanteswaraRao Talluri


On Dec. 5, 2014, 6:18 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28741/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 6:18 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8018
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8018
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1) Removed hard coded services data.
> 2) Changed variable names
> 3) Fixed pep8 issues
> 4) Now test cases read data from test_data.py
> 
> 
> Diffs
> -----
> 
>   test/integration/component/maint/test_redundant_router.py 75c6122 
> 
> Diff: https://reviews.apache.org/r/28741/diff/
> 
> 
> Testing
> -------
> 
> Yes. Only one test case is failing with assertion error, not related to these changes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message