cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 28741: CLOUDSTACK-8018: Improve code quality - test_redundant_router.py
Date Fri, 05 Dec 2014 06:18:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28741/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8018
    https://issues.apache.org/jira/browse/CLOUDSTACK-8018


Repository: cloudstack-git


Description
-------

1) Removed hard coded services data.
2) Changed variable names
3) Fixed pep8 issues
4) Now test cases read data from test_data.py


Diffs
-----

  test/integration/component/maint/test_redundant_router.py 75c6122 

Diff: https://reviews.apache.org/r/28741/diff/


Testing
-------

Yes. Only one test case is failing with assertion error, not related to these changes.


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message