Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23ABF10F42 for ; Thu, 27 Nov 2014 00:40:51 +0000 (UTC) Received: (qmail 70088 invoked by uid 500); 27 Nov 2014 00:40:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 70039 invoked by uid 500); 27 Nov 2014 00:40:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 70022 invoked by uid 99); 27 Nov 2014 00:40:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Nov 2014 00:40:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CBBAC1FB7D0; Thu, 27 Nov 2014 00:40:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6575771930168702282==" MIME-Version: 1.0 Subject: Re: Review Request 28490: CLOUDSTACK-7979 : Fixed the script 'test_security_groups.py' - Zone Network Type Information should to be passed to VirtualMachine create method From: "sangeetha hariharan" To: "sangeetha hariharan" Cc: "Chandan Purushothama" , "cloudstack" Date: Thu, 27 Nov 2014 00:40:48 -0000 Message-ID: <20141127004048.15977.46639@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "sangeetha hariharan" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/28490/ X-Sender: "sangeetha hariharan" References: <20141127001452.15978.14273@reviews.apache.org> In-Reply-To: <20141127001452.15978.14273@reviews.apache.org> Reply-To: "sangeetha hariharan" X-ReviewRequest-Repository: cloudstack-git --===============6575771930168702282== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28490/#review63165 ----------------------------------------------------------- Ship it! Ship It! - sangeetha hariharan On Nov. 27, 2014, 12:14 a.m., Chandan Purushothama wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28490/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 12:14 a.m.) > > > Review request for cloudstack and sangeetha hariharan. > > > Bugs: CLOUDSTACK-7979 > https://issues.apache.org/jira/browse/CLOUDSTACK-7979 > > > Repository: cloudstack-git > > > Description > ------- > > Currently, test cases in the test suite do not pass the Zone Network Type to the Virtual Machine class create method. This doesn't cause any problem with majority of the configurations except EIP-ELB Configuration. Hence Zone Network Type Information should be passed consciously to the create method to cover EIP-ELB Configuration. > > > Diffs > ----- > > test/integration/component/test_security_groups.py 89317f4 > > Diff: https://reviews.apache.org/r/28490/diff/ > > > Testing > ------- > > Executed One Test to prove the fix. This test belongs to a different test suite. But the fix is the same: > > Test authorize ingress rule ... === TestName: test_authorizeIngressRule | Status : SUCCESS === > ok > > > Ran 1 test in 126.613s > > OK > > > Thanks, > > Chandan Purushothama > > --===============6575771930168702282==--