Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2711021005869637514=="
MIME-Version: 1.0
Subject: Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not
 validated when updating LB
From: "Rajani Karuturi" <rajani@apache.org>
To: "Daniel Vega Simoes" <daniel.simoes@corp.globo.com>,
 "Rajani Karuturi" <rajani@apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 25 Nov 2014 08:15:56 -0000
Message-ID: <20141125081556.15978.52845@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Rajani Karuturi" <noreply@reviews.apache.org>
References: <20141125081412.15978.62166@reviews.apache.org>
In-Reply-To: <20141125081412.15978.62166@reviews.apache.org>
Reply-To: "Rajani Karuturi" <rajani@apache.org>

--===============2711021005869637514==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote:
> > Ship It!

Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa
will merge to master as well.


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28049/#review62950
-----------------------------------------------------------


On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28049/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 4:23 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917
> Validate Load Balancer rule with provider before commiting to DB and applying new rule.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 
>   server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28049/diff/
> 
> 
> Testing
> -------
> 
> Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java
>   - Test to guarantee that validate is being called when updating LB rule
>   - Test to guarantee that it throws exception if LB rule is not validated by provider
> 
> Ran integration tests (smoke), all seems OK.
> 
> 
> Thanks,
> 
> Daniel Vega Simoes
> 
>


--===============2711021005869637514==--