Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============4806044758157867219=="
MIME-Version: 1.0
Subject: Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values
 for Load Balancer algorithms in UI
From: "Rajani Karuturi" <rajani@apache.org>
To: "Daniel Vega Simoes" <daniel.simoes@corp.globo.com>,
 "Rajani Karuturi" <rajani@apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 25 Nov 2014 08:15:54 -0000
Message-ID: <20141125081554.15978.81626@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Rajani Karuturi" <noreply@reviews.apache.org>
References: <20141125081518.15978.89206@reviews.apache.org>
In-Reply-To: <20141125081518.15978.89206@reviews.apache.org>
Reply-To: "Rajani Karuturi" <rajani@apache.org>

--===============4806044758157867219==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 25, 2014, 8:15 a.m., Rajani Karuturi wrote:
> > Ship It!

pushed to 4.5 commit: ba6dfd84702eeef0362b94068add1328db84133a
will merge to master as well


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28043/#review62953
-----------------------------------------------------------


On Nov. 17, 2014, 6:26 p.m., Daniel Vega Simoes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28043/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:26 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> JIRA: CLOUDSTACK 7915
> 
> Removed hard-coded values for Load Balancer algorithms in UI. 
> 
> Instead, now UI sets values loaded dynamically through load balancer provider capabilities.
> 
> Also updated internationalization messages.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/classes/resources/messages.properties 86eb5c2 
>   client/WEB-INF/classes/resources/messages_ar.properties 4f65118 
>   client/WEB-INF/classes/resources/messages_es.properties f2d754e 
>   client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f 
>   client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b 
>   client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 
>   client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e 
>   client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 
>   client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 
>   client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 
>   client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba 
>   client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 
>   ui/dictionary.jsp 671f48f 
>   ui/scripts/network.js c27b999 
>   ui/scripts/vpc.js af19d87 
> 
> Diff: https://reviews.apache.org/r/28043/diff/
> 
> 
> Testing
> -------
> 
> Tests performed:
> - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI)
> - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI)
> 
> It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI.
> 
> 
> Thanks,
> 
> Daniel Vega Simoes
> 
>


--===============4806044758157867219==--