Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E606DCD95 for ; Mon, 24 Nov 2014 06:12:51 +0000 (UTC) Received: (qmail 56871 invoked by uid 500); 24 Nov 2014 06:12:51 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 56821 invoked by uid 500); 24 Nov 2014 06:12:51 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 56807 invoked by uid 99); 24 Nov 2014 06:12:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 06:12:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0BCCD1D9ECD; Mon, 24 Nov 2014 06:12:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0427305409881692458==" MIME-Version: 1.0 Subject: Review Request 28389: CLOUDSTACK-7963: Fixed test case in test_dedicate_guest_vlan_ranges.py From: "Ashutosh Kelkar" To: "sanjeev n" , "SrikanteswaraRao Talluri" Cc: "Ashutosh Kelkar" , "cloudstack" Date: Mon, 24 Nov 2014 06:12:50 -0000 Message-ID: <20141124061250.15978.58701@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Kelkar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/28389/ X-Sender: "Ashutosh Kelkar" Reply-To: "Ashutosh Kelkar" X-ReviewRequest-Repository: cloudstack-git --===============0427305409881692458== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28389/ ----------------------------------------------------------- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7963 https://issues.apache.org/jira/browse/CLOUDSTACK-7963 Repository: cloudstack-git Description ------- Test case failed with exception: int() argument must be a string or a number, not 'NoneType' It fails while checking if the vlan id of the network is from the dedicated range. The network does not get vlan id in the first place because it is not in implemented state. Solution: Either deploy a VM in the network or implement the network with persistent network offering Changes: Used persistent network offering instead of normal offering. Diffs ----- test/integration/component/test_dedicate_guest_vlan_ranges.py efba229 Diff: https://reviews.apache.org/r/28389/diff/ Testing ------- Release a dedicated vlan range when no vlan id is in use ... === TestName: test_05_release_range_vlan_in_use | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 1 test in 61.409s OK Thanks, Ashutosh Kelkar --===============0427305409881692458==--