Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE05E10768 for ; Wed, 19 Nov 2014 10:58:10 +0000 (UTC) Received: (qmail 98495 invoked by uid 500); 19 Nov 2014 10:58:10 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 98447 invoked by uid 500); 19 Nov 2014 10:58:10 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 98432 invoked by uid 99); 19 Nov 2014 10:58:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 10:58:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 623111DDA94; Wed, 19 Nov 2014 10:58:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8485488711077870736==" MIME-Version: 1.0 Subject: Re: Review Request 27464: Remove private key from listSslCerts From: "Will Stevens" To: "Will Stevens" Cc: "Syed Ahmed" , "cloudstack" Date: Wed, 19 Nov 2014 10:58:09 -0000 Message-ID: <20141119105809.24716.24573@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Will Stevens" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/27464/ X-Sender: "Will Stevens" References: <20141101142621.7137.74899@reviews.apache.org> In-Reply-To: <20141101142621.7137.74899@reviews.apache.org> Reply-To: "Will Stevens" X-ReviewRequest-Repository: cloudstack-git --===============8485488711077870736== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27464/#review62144 ----------------------------------------------------------- Ship it! I have tested this change on master this morning and everything works as expected... Ship It! - Will Stevens On Nov. 1, 2014, 2:26 p.m., Syed Ahmed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27464/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 2:26 p.m.) > > > Review request for cloudstack and Will Stevens. > > > Repository: cloudstack-git > > > Description > ------- > > Remove private key from listSslCerts > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/SslCertResponse.java 67011f9 > server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 695b935 > > Diff: https://reviews.apache.org/r/27464/diff/ > > > Testing > ------- > > > Thanks, > > Syed Ahmed > > --===============8485488711077870736==--