Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6663B10C4B for ; Wed, 19 Nov 2014 05:17:49 +0000 (UTC) Received: (qmail 25742 invoked by uid 500); 19 Nov 2014 05:17:48 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 25696 invoked by uid 500); 19 Nov 2014 05:17:48 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 25682 invoked by uid 99); 19 Nov 2014 05:17:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 05:17:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D5DA116BC1; Wed, 19 Nov 2014 05:17:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3024723075289167681==" MIME-Version: 1.0 Subject: Re: Review Request 28213: CLOUDSTACK-7752: Management Server goes in infinite loop while creating a vm with tagged local data disk when the pool is not tagged From: "Anshul Gangwar" To: "daan Hoogland" , "Rajesh Battala" Cc: "Anshul Gangwar" , "cloudstack" Date: Wed, 19 Nov 2014 05:17:47 -0000 Message-ID: <20141119051747.24716.94364@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Anshul Gangwar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/28213/ X-Sender: "Anshul Gangwar" References: <20141119050326.24717.1261@reviews.apache.org> In-Reply-To: <20141119050326.24717.1261@reviews.apache.org> Reply-To: "Anshul Gangwar" X-ReviewRequest-Repository: cloudstack-git --===============3024723075289167681== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28213/ ----------------------------------------------------------- (Updated Nov. 19, 2014, 5:17 a.m.) Review request for cloudstack, daan Hoogland and Rajesh Battala. Bugs: CLOUDSTACK-7752 https://issues.apache.org/jira/browse/CLOUDSTACK-7752 Repository: cloudstack-git Description ------- Fixed deployment planner stuck in infinite loop. If we create VM with shared service offering and attach disk with local disk offering, and one of storage pool is full(cannot be allocated) and other is not full then we are not putting the cluster in avoid list which is causing this infinite loop. Fixed by putting the cluster in avoid list even if one of the storage pool is full(cannot be allocated) Diffs ----- server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java d9e1ecc2291a72a04ee0c1b35a079d5ff166bf77 Diff: https://reviews.apache.org/r/28213/diff/ Testing ------- Thanks, Anshul Gangwar --===============3024723075289167681==--